From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rwuth-0000Is-PA for qemu-devel@nongnu.org; Mon, 13 Feb 2012 07:20:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rwutb-0006AC-7H for qemu-devel@nongnu.org; Mon, 13 Feb 2012 07:20:45 -0500 Received: from smtp.citrix.com ([66.165.176.89]:59977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rwutb-00069N-3E for qemu-devel@nongnu.org; Mon, 13 Feb 2012 07:20:39 -0500 From: Anthony PERARD Date: Mon, 13 Feb 2012 12:20:13 +0000 Message-ID: <1329135613-26061-12-git-send-email-anthony.perard@citrix.com> In-Reply-To: <1329135613-26061-1-git-send-email-anthony.perard@citrix.com> References: <1329135613-26061-1-git-send-email-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH V6 11/11] pci: Do not check if a bus exist in pci_parse_devaddr. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU-devel Cc: Anthony PERARD , Anthony Liguori , Xen Devel , "Michael S . Tsirkin" , Stefano Stabellini Actually, pci_parse_devaddr checks if the dom/bus of the PCI address exist. But this should be the jobs of a caller. In fact, the two callers of this function will try to retrieve the PCIBus related to the devaddr and return an error if they cannot. Signed-off-by: Anthony PERARD --- hw/pci.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index ebb5de9..da7cf79 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -529,10 +529,6 @@ int pci_parse_devaddr(const char *addr, int *domp, int *busp, if (*e) return -1; - /* Note: QEMU doesn't implement domains other than 0 */ - if (!pci_find_bus(pci_find_root_bus(dom), bus)) - return -1; - *domp = dom; *busp = bus; *slotp = slot; -- Anthony PERARD