From: bo.novell@gmail.com
To: qemu-devel@nongnu.org
Cc: Bo Yang <boyang@suse.com>
Subject: [Qemu-devel] [PATCH] RTL8139 hotplug is broken on windows 2008 sp2.
Date: Tue, 14 Feb 2012 11:10:19 +0800 [thread overview]
Message-ID: <1329189019-13710-1-git-send-email-bo.novell@gmail.com> (raw)
From: Bo Yang <boyang@suse.com>
Windows 2008 sp2 tries to read mac address from phys
and then write the read value into it. This patch
is a workaround for the issue.
Signed-off-by: Bo Yang <boyang@suse.com>
---
hw/rtl8139.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index 1668390..074a14a 100644
--- a/hw/rtl8139.c
+++ b/hw/rtl8139.c
@@ -3476,6 +3476,8 @@ static int pci_rtl8139_init(PCIDevice *dev)
s->eeprom.contents[7] = s->conf.macaddr.a[0] | s->conf.macaddr.a[1] << 8;
s->eeprom.contents[8] = s->conf.macaddr.a[2] | s->conf.macaddr.a[3] << 8;
s->eeprom.contents[9] = s->conf.macaddr.a[4] | s->conf.macaddr.a[5] << 8;
+ /* workaround broken windows 2008 sp2 driver. */
+ memcpy(s->phys, s->conf.macaddr.a, 6);
s->nic = qemu_new_nic(&net_rtl8139_info, &s->conf,
object_get_typename(OBJECT(dev)), dev->qdev.id, s);
--
1.6.0.2
next reply other threads:[~2012-02-14 3:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 3:10 bo.novell [this message]
2012-05-09 20:20 ` [Qemu-devel] [PATCH] RTL8139 hotplug is broken on windows 2008 sp2 Andreas Färber
2012-05-09 21:00 ` Alexander Graf
2012-05-09 21:05 ` Andreas Färber
2012-05-09 21:06 ` Alexander Graf
2012-05-09 21:27 ` Bruce Rogers
2012-05-09 21:38 ` Andreas Färber
2012-05-10 16:31 ` Bo Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329189019-13710-1-git-send-email-bo.novell@gmail.com \
--to=bo.novell@gmail.com \
--cc=boyang@suse.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).