From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rxg74-0001fd-DK for qemu-devel@nongnu.org; Wed, 15 Feb 2012 09:45:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rxg6y-0000Wz-Iq for qemu-devel@nongnu.org; Wed, 15 Feb 2012 09:45:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rxg6y-0000Wt-C9 for qemu-devel@nongnu.org; Wed, 15 Feb 2012 09:45:36 -0500 From: Gerd Hoffmann Date: Wed, 15 Feb 2012 15:45:30 +0100 Message-Id: <1329317130-18859-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH v2] qxl: don't render stuff when the vm is stopped. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: spice-devel@lists.freedesktop.org, Gerd Hoffmann This patch fixes the local qxl renderer to not kick spice-server in case the vm is stopped. First it is largely pointless because we ask spice-server to process all not-yet processed commands when the vm is stopped, so there isn't much do do anyway. Second we avoid triggering an assert in spice-server. The patch makes sure we still honor redraw requests, even if we don't ask spice-server for updates. This is needed to handle displaysurface changes with a stopped vm correctly. With this patch applied it is possible to take screen shots (via screendump monitor command) from a qxl gpu even in case the guest is stopped. Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c | 12 +++++------- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/qxl-render.c b/hw/qxl-render.c index 133d093..7084143 100644 --- a/hw/qxl-render.c +++ b/hw/qxl-render.c @@ -121,19 +121,17 @@ void qxl_render_update(PCIQXLDevice *qxl) dpy_resize(vga->ds); } - if (!qxl->guest_primary.commands) { - return; - } - qxl->guest_primary.commands = 0; - update.left = 0; update.right = qxl->guest_primary.surface.width; update.top = 0; update.bottom = qxl->guest_primary.surface.height; memset(dirty, 0, sizeof(dirty)); - qxl_spice_update_area(qxl, 0, &update, - dirty, ARRAY_SIZE(dirty), 1, QXL_SYNC); + if (runstate_is_running() && qxl->guest_primary.commands) { + qxl->guest_primary.commands = 0; + qxl_spice_update_area(qxl, 0, &update, + dirty, ARRAY_SIZE(dirty), 1, QXL_SYNC); + } if (redraw) { memset(dirty, 0, sizeof(dirty)); dirty[0] = update; -- 1.7.1