From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rxh4V-0007O4-ES for qemu-devel@nongnu.org; Wed, 15 Feb 2012 10:47:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rxh47-0004hA-F5 for qemu-devel@nongnu.org; Wed, 15 Feb 2012 10:47:07 -0500 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:40911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rxh46-0004gY-Ry for qemu-devel@nongnu.org; Wed, 15 Feb 2012 10:46:43 -0500 Received: from /spool/local by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 15 Feb 2012 21:16:40 +0530 Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q1FFkaEB3948770 for ; Wed, 15 Feb 2012 21:16:36 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q1FFkYTK025512 for ; Thu, 16 Feb 2012 02:46:35 +1100 From: Harsh Prateek Bora Date: Wed, 15 Feb 2012 21:16:20 +0530 Message-Id: <1329320783-6365-12-git-send-email-harsh@linux.vnet.ibm.com> In-Reply-To: <1329320783-6365-1-git-send-email-harsh@linux.vnet.ibm.com> References: <1329320783-6365-1-git-send-email-harsh@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [RFC PATCH v4 11/14] trace: [tracetool] Add error-reporting functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: stefanha@gmail.com, vilanova@ac.upc.edu, aneesh.kumar@linux.vnet.ibm.com From: Lluís Vilanova Signed-off-by: Lluís Vilanova Signed-off-by: Harsh Prateek Bora --- scripts/tracetool.py | 27 +++++++++++++++------------ 1 files changed, 15 insertions(+), 12 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index dc93a1a..6cbbdd7 100755 --- a/scripts/tracetool.py +++ b/scripts/tracetool.py @@ -63,6 +63,13 @@ def get_format_descr(format_): return "" +def error_write(*lines): + sys.stderr.writelines(lines) + +def error(*lines): + error_write(*lines) + sys.exit(1) + ###################################################################### # backend auto-registration and format compatibility @@ -521,8 +528,9 @@ def main(): try: opts, args = getopt.getopt(sys.argv[1:], "", long_options) except getopt.GetoptError, err: - # print help information and exit: - print str(err) # will print something like "option -a not recognized" + # print help information and exit + # will print something like "option -a not recognized" + error_write(str(err)+"\n") usage() sys.exit(2) for opt, arg in opts: @@ -551,24 +559,19 @@ def main(): usage() if format_ not in _formats: - print "Unknown format: %s" % format_ - print + error_write("Unknown format: %s\n\n" % format_) usage() if backend not in _backends: - print "Unknown backend: %s" % backend - print + error_write("Unknown backend: %s\n\n" % backend) usage() if format_ == 'stap': if binary == "": - print '--binary is required for SystemTAP tapset generator' - sys.exit(1) + error("--binary is required for SystemTAP tapset generator\n") if not probeprefix and not targettype: - print '--target-type is required for SystemTAP tapset generator' - sys.exit(1) + error("--target-type is required for SystemTAP tapset generator\n") if not probeprefix and not targetarch: - print '--target-arch is required for SystemTAP tapset generator' - sys.exit(1) + error("--target-arch is required for SystemTAP tapset generator\n") if probeprefix == "": probeprefix = 'qemu.' + targettype + '.' + targetarch -- 1.7.1.1