From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyMEU-0002ER-5O for qemu-devel@nongnu.org; Fri, 17 Feb 2012 06:44:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyMEN-0001E4-51 for qemu-devel@nongnu.org; Fri, 17 Feb 2012 06:44:10 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:62383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyMEM-0001Du-Qn for qemu-devel@nongnu.org; Fri, 17 Feb 2012 06:44:03 -0500 Received: by dadp14 with SMTP id p14so3873676dad.4 for ; Fri, 17 Feb 2012 03:44:01 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 17 Feb 2012 12:43:46 +0100 Message-Id: <1329479028-27650-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1329479028-27650-1-git-send-email-pbonzini@redhat.com> References: <1329479028-27650-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] do not chdir(/) in qemu-nbd before opening all files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Tokarev From: Michael Tokarev When qemu-nbd becomes a daemon it calls daemon(3) with nochdir=0, so daemon(3) changes current directory to /. But at this time, qemu-nbd did not open any user-specified files yet, so by changing current directory, all non-absolute paths becomes wrong. The solution is to pass nochdir=1 to daemon(3) function, and to chdir("/") after all init has been performed, before entering the main loop, -- just like a good daemon should do. This patch is applicable for -stable. Signed-off-by: Michael Tokarev Signed-off-by: Paolo Bonzini --- qemu-nbd.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index eb61c33..e189cf8 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -429,7 +429,7 @@ int main(int argc, char **argv) pid = fork(); if (pid == 0) { close(stderr_fd[0]); - ret = qemu_daemon(0, 0); + ret = qemu_daemon(1, 0); /* Temporarily redirect stderr to the parent's pipe... */ dup2(stderr_fd[1], STDERR_FILENO); @@ -527,6 +527,12 @@ int main(int argc, char **argv) qemu_set_fd_handler2(fd, nbd_can_accept, nbd_accept, NULL, (void *)(uintptr_t)fd); + /* now when the initialization is (almost) complete, chdir("/") + * to free any busy filesystems */ + if (chdir("/") < 0) { + err(EXIT_FAILURE, "Could not chdir to root directory"); + } + do { main_loop_wait(false); } while (!sigterm_reported && (persistent || !nbd_started || nb_fds > 0)); -- 1.7.7.6