From: Meador Inge <meadori@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v1 1/1] exec: Fix watchpoint implementation
Date: Fri, 17 Feb 2012 10:23:01 -0600 [thread overview]
Message-ID: <1329495781-5264-1-git-send-email-meadori@codesourcery.com> (raw)
Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f
where 'watch_mem_write' was modified to fall-through to 'abort' on
every input.
Signed-off-by: Meador Inge <meadori@codesourcery.com>
---
exec.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/exec.c b/exec.c
index b81677a..fe8b2d1 100644
--- a/exec.c
+++ b/exec.c
@@ -3289,9 +3289,9 @@ static void watch_mem_write(void *opaque, target_phys_addr_t addr,
{
check_watchpoint(addr & ~TARGET_PAGE_MASK, ~(size - 1), BP_MEM_WRITE);
switch (size) {
- case 1: stb_phys(addr, val);
- case 2: stw_phys(addr, val);
- case 4: stl_phys(addr, val);
+ case 1: return stb_phys(addr, val);
+ case 2: return stw_phys(addr, val);
+ case 4: return stl_phys(addr, val);
default: abort();
}
}
--
1.7.7.6
next reply other threads:[~2012-02-17 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 16:23 Meador Inge [this message]
2012-02-17 16:28 ` [Qemu-devel] [PATCH v1 1/1] exec: Fix watchpoint implementation Jan Kiszka
2012-02-17 16:36 ` Meador Inge
2012-02-17 16:44 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329495781-5264-1-git-send-email-meadori@codesourcery.com \
--to=meadori@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).