From: Anthony PERARD <anthony.perard@citrix.com>
To: QEMU-devel <qemu-devel@nongnu.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Yuji Shimada <shimada-yxb@necst.nec.co.jp>,
Xen Devel <xen-devel@lists.xensource.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [Qemu-devel] [PATCH V7 06/11] pci.c: Add pci_check_bar_overlap
Date: Fri, 17 Feb 2012 17:08:40 +0000 [thread overview]
Message-ID: <1329498525-8454-7-git-send-email-anthony.perard@citrix.com> (raw)
In-Reply-To: <1329498525-8454-1-git-send-email-anthony.perard@citrix.com>
From: Yuji Shimada <shimada-yxb@necst.nec.co.jp>
This function helps Xen PCI Passthrough device to check for overlap.
Signed-off-by: Yuji Shimada <shimada-yxb@necst.nec.co.jp>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
hw/pci.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
hw/pci.h | 3 +++
2 files changed, 50 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 678a8c1..75d6529 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -1985,6 +1985,53 @@ MemoryRegion *pci_address_space_io(PCIDevice *dev)
return dev->bus->address_space_io;
}
+int pci_check_bar_overlap(PCIDevice *dev,
+ pcibus_t addr, pcibus_t size, uint8_t type)
+{
+ PCIBus *bus = dev->bus;
+ PCIDevice *devices = NULL;
+ PCIIORegion *r;
+ int i, j;
+ int rc = 0;
+
+ /* check Overlapped to Base Address */
+ for (i = 0; i < ARRAY_SIZE(bus->devices); i++) {
+ devices = bus->devices[i];
+ if (!devices) {
+ continue;
+ }
+
+ /* skip itself */
+ if (devices->devfn == dev->devfn) {
+ continue;
+ }
+
+ for (j = 0; j < PCI_NUM_REGIONS; j++) {
+ r = &devices->io_regions[j];
+
+ /* skip different resource type, but don't skip when
+ * prefetch and non-prefetch memory are compared.
+ */
+ if (type != r->type) {
+ if (type & PCI_BASE_ADDRESS_SPACE_IO ||
+ r->type & PCI_BASE_ADDRESS_SPACE_IO) {
+ continue;
+ }
+ }
+
+ if ((addr < (r->addr + r->size)) && ((addr + size) > r->addr)) {
+ printf("Overlapped to device[%02x:%02x.%x][Region:%d]"
+ "[Address:%"PRIx64"h][Size:%"PRIx64"h]\n",
+ pci_bus_num(bus), PCI_SLOT(devices->devfn),
+ PCI_FUNC(devices->devfn), j, r->addr, r->size);
+ rc = 1;
+ }
+ }
+ }
+
+ return rc;
+}
+
static void pci_device_class_init(ObjectClass *klass, void *data)
{
DeviceClass *k = DEVICE_CLASS(klass);
diff --git a/hw/pci.h b/hw/pci.h
index 33b0b18..f05fda5 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -566,4 +566,7 @@ extern const VMStateDescription vmstate_pci_device;
.offset = vmstate_offset_pointer(_state, _field, PCIDevice), \
}
+int pci_check_bar_overlap(PCIDevice *dev,
+ pcibus_t addr, pcibus_t size, uint8_t type);
+
#endif
--
Anthony PERARD
next prev parent reply other threads:[~2012-02-17 17:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 17:08 [Qemu-devel] [PATCH V7 00/11] Xen PCI Passthrough Anthony PERARD
2012-02-17 17:08 ` [Qemu-devel] [PATCH V7 01/11] pci_ids: Add INTEL_82599_VF id Anthony PERARD
2012-02-17 17:08 ` [Qemu-devel] [PATCH V7 02/11] pci_regs: Fix value of PCI_EXP_TYPE_RC_EC Anthony PERARD
2012-02-20 20:27 ` Michael S. Tsirkin
2012-02-17 17:08 ` [Qemu-devel] [PATCH V7 03/11] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE Anthony PERARD
2012-02-20 20:30 ` Michael S. Tsirkin
2012-02-21 16:07 ` Anthony PERARD
2012-02-23 20:20 ` Michael S. Tsirkin
2012-02-17 17:08 ` [Qemu-devel] [PATCH V7 04/11] configure: Introduce --enable-xen-pci-passthrough Anthony PERARD
2012-02-17 17:08 ` [Qemu-devel] [PATCH V7 05/11] Introduce HostPCIDevice to access a pci device on the host Anthony PERARD
2012-02-17 17:08 ` Anthony PERARD [this message]
2012-02-19 13:35 ` [Qemu-devel] [PATCH V7 06/11] pci.c: Add pci_check_bar_overlap Michael S. Tsirkin
2012-02-28 11:19 ` Anthony PERARD
2012-02-17 17:08 ` [Qemu-devel] [PATCH V7 07/11] Introduce Xen PCI Passthrough, qdevice (1/3) Anthony PERARD
2012-02-17 17:08 ` [Qemu-devel] [PATCH V7 08/11] Introduce Xen PCI Passthrough, PCI config space helpers (2/3) Anthony PERARD
2012-02-19 13:32 ` Michael S. Tsirkin
2012-02-20 20:35 ` Michael S. Tsirkin
2012-02-21 10:18 ` Stefano Stabellini
2012-02-17 17:08 ` [Qemu-devel] [PATCH V7 09/11] Introduce apic-msidef.h Anthony PERARD
2012-02-17 17:08 ` [Qemu-devel] [PATCH V7 10/11] Introduce Xen PCI Passthrough, MSI (3/3) Anthony PERARD
2012-02-17 17:08 ` [Qemu-devel] [PATCH V7 11/11] xen passthrough: clean up MSI-X table handling Anthony PERARD
2012-02-21 9:34 ` Jan Beulich
2012-02-21 16:15 ` Anthony PERARD
2012-02-20 10:51 ` [Qemu-devel] [Xen-devel] [PATCH V7 00/11] Xen PCI Passthrough Tobias Geiger
2012-02-20 11:31 ` Anthony PERARD
2012-02-20 16:11 ` Tobias Geiger
2012-02-20 17:08 ` Anthony PERARD
2012-02-20 19:58 ` Tobias Geiger
2012-02-20 23:31 ` Anthony PERARD
2012-02-22 14:56 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329498525-8454-7-git-send-email-anthony.perard@citrix.com \
--to=anthony.perard@citrix.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shimada-yxb@necst.nec.co.jp \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).