qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com, Max Filippov <jcmvbkbc@gmail.com>,
	aliguori@us.ibm.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH 09/12] exec: let cpu_watchpoint_insert accept larger watchpoints
Date: Sat, 18 Feb 2012 21:11:40 +0400	[thread overview]
Message-ID: <1329585103-31371-9-git-send-email-jcmvbkbc@gmail.com> (raw)
In-Reply-To: <1329585103-31371-1-git-send-email-jcmvbkbc@gmail.com>

Make cpu_watchpoint_insert accept watchpoints of any power-of-two size
up to the target page size.

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 exec.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/exec.c b/exec.c
index ed091f3..80560fa 100644
--- a/exec.c
+++ b/exec.c
@@ -1443,7 +1443,8 @@ int cpu_watchpoint_insert(CPUState *env, target_ulong addr, target_ulong len,
     CPUWatchpoint *wp;
 
     /* sanity checks: allow power-of-2 lengths, deny unaligned watchpoints */
-    if ((len != 1 && len != 2 && len != 4 && len != 8) || (addr & ~len_mask)) {
+    if ((len & (len - 1)) || (addr & ~len_mask) ||
+            len == 0 || len > TARGET_PAGE_SIZE) {
         fprintf(stderr, "qemu: tried to set invalid watchpoint at "
                 TARGET_FMT_lx ", len=" TARGET_FMT_lu "\n", addr, len);
         return -EINVAL;
-- 
1.7.7.6

  parent reply	other threads:[~2012-02-18 17:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-18 11:30 [Qemu-devel] [PULL 00/12] target-xtensa queue Max Filippov
2012-02-18 16:36 ` Andreas Färber
2012-02-18 17:11 ` [Qemu-devel] [PATCH 01/12] target-xtensa: define TLB_TEMPLATE for MMU-less cores Max Filippov
2012-02-18 17:11   ` [Qemu-devel] [PATCH 02/12] target-xtensa: implement info tlb monitor command Max Filippov
2012-02-18 17:11   ` [Qemu-devel] [PATCH 03/12] target-xtensa: fetch 3rd opcode byte only when needed Max Filippov
2012-02-18 17:11   ` [Qemu-devel] [PATCH 04/12] target-xtensa: add DEBUGCAUSE SR and configuration Max Filippov
2012-02-18 17:11   ` [Qemu-devel] [PATCH 05/12] target-xtensa: implement instruction breakpoints Max Filippov
2012-02-18 17:11   ` [Qemu-devel] [PATCH 06/12] target-xtensa: add ICOUNT SR and debug exception Max Filippov
2012-02-18 17:11   ` [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the watch_mem_write Max Filippov
2012-02-18 17:51     ` Andreas Färber
2012-02-18 18:13       ` Max Filippov
2012-02-20 14:12     ` Meador Inge
2012-02-18 17:11   ` [Qemu-devel] [PATCH 08/12] exec: fix check_watchpoint exiting cpu_loop Max Filippov
2012-02-18 17:11   ` Max Filippov [this message]
2012-02-18 17:11   ` [Qemu-devel] [PATCH 10/12] target-xtensa: add DBREAK data breakpoints Max Filippov
2012-02-18 17:11   ` [Qemu-devel] [PATCH 11/12] target-xtensa: add DEBUG_SECTION to overlay tool Max Filippov
2012-02-18 17:11   ` [Qemu-devel] [PATCH 12/12] target-xtensa: add breakpoint tests Max Filippov
2012-02-26 17:34 ` [Qemu-devel] [PULL 00/12] target-xtensa queue Max Filippov
2012-03-03 17:56   ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329585103-31371-9-git-send-email-jcmvbkbc@gmail.com \
    --to=jcmvbkbc@gmail.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).