[Qemu-devel] [PATCH 1/2] qemu-img: fix segment fault when the image format is qed

[Qemu-devel] [PATCH 1/2] qemu-img: fix segment fault when the image format is qed

[zwu.kernel]

From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>

[root@f15 qemu]# qemu-img info /home/zwu/work/misc/rh6.img
image: /home/zwu/work/misc/rh6.img
file format: qed
virtual size: 4.0G (4294967296 bytes)
disk size: 1.2G
cluster_size: 65536
Segmentation fault (core dumped)

Today when i were fixing another issue, i found this issue; After simple investigation, i found that the required clock vm_clock is not created for qemu tool.

Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
 qemu-img.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/qemu-img.c b/qemu-img.c
index c4bcf41..8df3564 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1655,6 +1655,8 @@ int main(int argc, char **argv)
     cmdname = argv[1];
     argc--; argv++;
 
+    qemu_init_main_loop();
+
     /* find the command */
     for(cmd = img_cmds; cmd->name != NULL; cmd++) {
         if (!strcmp(cmdname, cmd->name)) {
-- 
1.7.6

Re: [Qemu-devel] [PATCH 1/2] qemu-img: fix segment fault when the image format is qed

[Stefan Hajnoczi]

On Sun, Feb 19, 2012 at 2:24 PM,  <zwu.kernel@gmail.com> wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> [root@f15 qemu]# qemu-img info /home/zwu/work/misc/rh6.img
> image: /home/zwu/work/misc/rh6.img
> file format: qed
> virtual size: 4.0G (4294967296 bytes)
> disk size: 1.2G
> cluster_size: 65536
> Segmentation fault (core dumped)
>
> Today when i were fixing another issue, i found this issue; After simple investigation, i found that the required clock vm_clock is not created for qemu tool.
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
>  qemu-img.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Please also see the "qed: replace vm_clock with rt_clock for qemu-tool
compatibility" patch which I just sent.  Using vm_clock is not
possible in qemu-tool and leads to abort(3) when running qemu-io write
commands.

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Re: [Qemu-devel] [PATCH 1/2] qemu-img: fix segment fault when the image format is qed

[Kevin Wolf]

Am 19.02.2012 15:24, schrieb zwu.kernel@gmail.com:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> 
> [root@f15 qemu]# qemu-img info /home/zwu/work/misc/rh6.img
> image: /home/zwu/work/misc/rh6.img
> file format: qed
> virtual size: 4.0G (4294967296 bytes)
> disk size: 1.2G
> cluster_size: 65536
> Segmentation fault (core dumped)
> 
> Today when i were fixing another issue, i found this issue; After simple investigation, i found that the required clock vm_clock is not created for qemu tool.
> 
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>

Thanks, applied both to the block branch.

Kevin