From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail
Date: Thu, 23 Feb 2012 16:16:00 +0000 [thread overview]
Message-ID: <1330013760-25793-1-git-send-email-peter.maydell@linaro.org> (raw)
Improve the configure test for presence of ucontext functions by
making linker warnings fatal; this allows us to detect when we are
linked with a glibc which implements makecontext() to always return
ENOSYS.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Compiling on an Ubuntu Natty ARM host will hit this.
(Anybody think we should clean up our configure tests so we can
enable -Werror and -Wl,--fatal-warnings on all of them?)
configure | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 9b4fe34..4d9d9e0 100755
--- a/configure
+++ b/configure
@@ -2549,9 +2549,12 @@ ucontext_coroutine=no
if test "$darwin" != "yes"; then
cat > $TMPC << EOF
#include <ucontext.h>
-int main(void) { makecontext(0, 0, 0); }
+int main(void) { makecontext(0, 0, 0); return 0; }
EOF
- if compile_prog "" "" ; then
+ # Note that we enable fatal linker warnings to catch the
+ # glibc "makecontext is not implemented and will always fail"
+ # linker warning.
+ if compile_prog "-Wl,--fatal-warnings" "" ; then
ucontext_coroutine=yes
fi
fi
--
1.7.4.1
next reply other threads:[~2012-02-23 16:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 16:16 Peter Maydell [this message]
2012-02-23 16:19 ` [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2011-10-12 16:21 Peter Maydell
2011-10-13 14:26 ` Andreas Färber
2011-10-13 22:23 ` Andreas Färber
2011-10-14 12:30 ` Peter Maydell
2011-10-14 12:47 ` Paolo Bonzini
2011-10-14 12:55 ` Paolo Bonzini
2011-10-14 13:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330013760-25793-1-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).