From: David Gibson <david@gibson.dropbear.id.au>
To: anthony@codemonkey.ws
Cc: David Gibson <david@gibson.dropbear.id.au>,
qemu-devel@nongnu.org, Gerd Hoffman <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 5/6] Endian fix an assertion in usb-msd
Date: Fri, 24 Feb 2012 11:23:31 +1100 [thread overview]
Message-ID: <1330043012-30556-6-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1330043012-30556-1-git-send-email-david@gibson.dropbear.id.au>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This fixes a broken endian assumption in an assertion in usb-msd.
Cc: Gerd Hoffman <kraxel@redhat.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/usb-msd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/usb-msd.c b/hw/usb-msd.c
index c933efe..2e0da27 100644
--- a/hw/usb-msd.c
+++ b/hw/usb-msd.c
@@ -195,7 +195,7 @@ static void usb_msd_send_status(MSDState *s, USBPacket *p)
DPRINTF("Command status %d tag 0x%x, len %zd\n",
s->csw.status, s->csw.tag, p->iov.size);
- assert(s->csw.sig == 0x53425355);
+ assert(s->csw.sig == cpu_to_le32(0x53425355));
len = MIN(sizeof(s->csw), p->iov.size);
usb_packet_copy(p, &s->csw, len);
memset(&s->csw, 0, sizeof(s->csw));
--
1.7.9
next prev parent reply other threads:[~2012-02-24 0:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 0:23 [Qemu-devel] [0/6] Assorted bugfixes David Gibson
2012-02-24 0:23 ` [Qemu-devel] [PATCH 1/6] kvm: Comparison with ioctl number macros needs to be unsigned David Gibson
2012-02-24 0:23 ` [Qemu-devel] [PATCH 2/6] slirp: Fix assertion failure on rejected DHCP requests David Gibson
2012-02-27 13:58 ` Jan Kiszka
2012-02-28 1:07 ` David Gibson
2012-02-24 0:23 ` [Qemu-devel] [PATCH 3/6] USB OHCI bug fixes David Gibson
2012-02-27 14:13 ` Gerd Hoffmann
2012-02-28 3:09 ` David Gibson
2012-02-28 3:37 ` David Gibson
2012-02-24 0:23 ` [Qemu-devel] [PATCH 4/6] Endian fixes for virtfs David Gibson
2012-02-24 8:29 ` Aneesh Kumar K.V
2012-02-24 0:23 ` David Gibson [this message]
2012-02-24 0:23 ` [Qemu-devel] [PATCH 6/6] kvm: Fix dirty tracking with large kernel page size David Gibson
2012-02-24 1:03 ` Benjamin Herrenschmidt
2012-02-26 21:41 ` Blue Swirl
2012-02-27 0:16 ` David Gibson
2012-02-27 0:25 ` Benjamin Herrenschmidt
2012-02-27 0:36 ` Alexander Graf
2012-03-03 15:29 ` Blue Swirl
2012-02-28 12:32 ` Avi Kivity
2012-02-28 21:48 ` Benjamin Herrenschmidt
2012-03-04 10:49 ` Avi Kivity
2012-03-04 11:53 ` Benjamin Herrenschmidt
2012-03-04 12:18 ` Avi Kivity
2012-03-04 16:46 ` Andreas Färber
2012-03-04 18:46 ` Alexander Graf
2012-03-04 20:21 ` Andreas Färber
2012-03-04 20:25 ` Alexander Graf
2012-03-04 20:31 ` Andreas Färber
2012-03-04 20:59 ` Alexander Graf
2012-03-04 21:19 ` Benjamin Herrenschmidt
2012-03-04 21:45 ` Alexander Graf
2012-03-04 21:21 ` Andreas Färber
2012-03-04 21:17 ` Benjamin Herrenschmidt
2012-02-28 23:32 ` Alexander Graf
2012-02-29 0:22 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330043012-30556-6-git-send-email-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).