From: Stefan Weil <sw@weilnetz.de>
To: malc <av1474@comtv.ru>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] audio: Add some fall through comments
Date: Sat, 25 Feb 2012 14:46:55 +0100 [thread overview]
Message-ID: <1330177615-25375-1-git-send-email-sw@weilnetz.de> (raw)
Static code analysers expect these comments for case statements without
a break statement.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
audio/audio.c | 3 +++
audio/esdaudio.c | 2 +-
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index 5fff6de..398763f 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -585,17 +585,20 @@ static int audio_pcm_info_eq (struct audio_pcm_info *info, struct audsettings *a
switch (as->fmt) {
case AUD_FMT_S8:
sign = 1;
+ /* fall through */
case AUD_FMT_U8:
break;
case AUD_FMT_S16:
sign = 1;
+ /* fall through */
case AUD_FMT_U16:
bits = 16;
break;
case AUD_FMT_S32:
sign = 1;
+ /* fall through */
case AUD_FMT_U32:
bits = 32;
break;
diff --git a/audio/esdaudio.c b/audio/esdaudio.c
index bd6e1cc..eea9cce 100644
--- a/audio/esdaudio.c
+++ b/audio/esdaudio.c
@@ -201,7 +201,7 @@ static int qesd_init_out (HWVoiceOut *hw, struct audsettings *as)
case AUD_FMT_S32:
case AUD_FMT_U32:
dolog ("Will use 16 instead of 32 bit samples\n");
-
+ /* fall through */
case AUD_FMT_S16:
case AUD_FMT_U16:
deffmt:
--
1.7.9
next reply other threads:[~2012-02-25 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 13:46 Stefan Weil [this message]
2012-02-25 14:16 ` [Qemu-devel] [PATCH] audio: Add some fall through comments malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330177615-25375-1-git-send-email-sw@weilnetz.de \
--to=sw@weilnetz.de \
--cc=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).