* [Qemu-devel] [PATCH] audio: Add some fall through comments
@ 2012-02-25 13:46 Stefan Weil
2012-02-25 14:16 ` malc
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2012-02-25 13:46 UTC (permalink / raw)
To: malc; +Cc: Stefan Weil, qemu-devel
Static code analysers expect these comments for case statements without
a break statement.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
audio/audio.c | 3 +++
audio/esdaudio.c | 2 +-
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index 5fff6de..398763f 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -585,17 +585,20 @@ static int audio_pcm_info_eq (struct audio_pcm_info *info, struct audsettings *a
switch (as->fmt) {
case AUD_FMT_S8:
sign = 1;
+ /* fall through */
case AUD_FMT_U8:
break;
case AUD_FMT_S16:
sign = 1;
+ /* fall through */
case AUD_FMT_U16:
bits = 16;
break;
case AUD_FMT_S32:
sign = 1;
+ /* fall through */
case AUD_FMT_U32:
bits = 32;
break;
diff --git a/audio/esdaudio.c b/audio/esdaudio.c
index bd6e1cc..eea9cce 100644
--- a/audio/esdaudio.c
+++ b/audio/esdaudio.c
@@ -201,7 +201,7 @@ static int qesd_init_out (HWVoiceOut *hw, struct audsettings *as)
case AUD_FMT_S32:
case AUD_FMT_U32:
dolog ("Will use 16 instead of 32 bit samples\n");
-
+ /* fall through */
case AUD_FMT_S16:
case AUD_FMT_U16:
deffmt:
--
1.7.9
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-25 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-25 13:46 [Qemu-devel] [PATCH] audio: Add some fall through comments Stefan Weil
2012-02-25 14:16 ` malc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).