From: Stefan Weil <sw@weilnetz.de>
To: Paul Brook <paul@codesourcery.com>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] ds1338: Add missing break statement
Date: Sat, 25 Feb 2012 14:50:25 +0100 [thread overview]
Message-ID: <1330177825-7618-1-git-send-email-sw@weilnetz.de> (raw)
Without the break statement, case 5 sets month and year from the same
data. This does not look correct.
The missing break was reported by splint.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/ds1338.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/ds1338.c b/hw/ds1338.c
index 6397f0a..d590d9c 100644
--- a/hw/ds1338.c
+++ b/hw/ds1338.c
@@ -100,6 +100,7 @@ static int ds1338_send(I2CSlave *i2c, uint8_t data)
break;
case 5:
s->now.tm_mon = from_bcd(data & 0x1f) - 1;
+ break;
case 6:
s->now.tm_year = from_bcd(data) + 100;
break;
--
1.7.9
next reply other threads:[~2012-02-25 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 13:50 Stefan Weil [this message]
2012-02-25 16:06 ` [Qemu-devel] [PATCH] ds1338: Add missing break statement Peter Maydell
2012-03-10 19:20 ` Stefan Weil
2012-03-10 20:34 ` Andreas Färber
2012-03-15 10:16 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330177825-7618-1-git-send-email-sw@weilnetz.de \
--to=sw@weilnetz.de \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).