From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerhard Wiesinger <lists@wiesinger.com>
Subject: [Qemu-devel] [PATCH 1/2] qdev: accept empty string properties
Date: Tue, 28 Feb 2012 09:54:14 +0100 [thread overview]
Message-ID: <1330419255-5566-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1330419255-5566-1-git-send-email-pbonzini@redhat.com>
These were stored as NULL due to wrong cut-and-paste from set_pointer.
Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/qdev-properties.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 0423af1..bff9152 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -421,10 +421,6 @@ static void set_string(Object *obj, Visitor *v, void *opaque,
error_propagate(errp, local_err);
return;
}
- if (!*str) {
- g_free(str);
- str = NULL;
- }
if (*ptr) {
g_free(*ptr);
}
--
1.7.7.6
next prev parent reply other threads:[~2012-02-28 8:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 8:54 [Qemu-devel] [PATCH 0/2] Two small QOM fixes Paolo Bonzini
2012-02-28 8:54 ` Paolo Bonzini [this message]
2012-02-28 18:53 ` [Qemu-devel] [PATCH 1/2] qdev: accept empty string properties Gerhard Wiesinger
2012-03-10 13:14 ` Andreas Färber
2012-02-28 8:54 ` [Qemu-devel] [PATCH 2/2] qom: fix device hot-unplug Paolo Bonzini
2012-03-10 13:12 ` Andreas Färber
2012-03-09 20:15 ` [Qemu-devel] [PATCH 0/2] Two small QOM fixes Paolo Bonzini
2012-03-13 1:59 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330419255-5566-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=lists@wiesinger.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).