From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2lF0-0005aS-Nk for qemu-devel@nongnu.org; Wed, 29 Feb 2012 10:15:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2lEq-0003Rx-Mh for qemu-devel@nongnu.org; Wed, 29 Feb 2012 10:14:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2lEq-0003Ra-EM for qemu-devel@nongnu.org; Wed, 29 Feb 2012 10:14:44 -0500 From: Kevin Wolf Date: Wed, 29 Feb 2012 16:17:44 +0100 Message-Id: <1330528688-21996-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1330528688-21996-1-git-send-email-kwolf@redhat.com> References: <1330528688-21996-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 03/27] fdc: most control commands do not generate interrupts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Herv=C3=A9 Poussineau In fact, only three control commands generate an interrupt: read_id, recalibrate and seek Signed-off-by: Herv=C3=A9 Poussineau Signed-off-by: Kevin Wolf --- hw/fdc.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 05edc3a..9d1f5b3 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1348,7 +1348,7 @@ static void fdctrl_handle_lock(FDCtrl *fdctrl, int = direction) { fdctrl->lock =3D (fdctrl->fifo[0] & 0x80) ? 1 : 0; fdctrl->fifo[0] =3D fdctrl->lock << 4; - fdctrl_set_fifo(fdctrl, 1, fdctrl->lock); + fdctrl_set_fifo(fdctrl, 1, 0); } =20 static void fdctrl_handle_dumpreg(FDCtrl *fdctrl, int direction) @@ -1380,7 +1380,7 @@ static void fdctrl_handle_version(FDCtrl *fdctrl, i= nt direction) { /* Controller's version */ fdctrl->fifo[0] =3D fdctrl->version; - fdctrl_set_fifo(fdctrl, 1, 1); + fdctrl_set_fifo(fdctrl, 1, 0); } =20 static void fdctrl_handle_partid(FDCtrl *fdctrl, int direction) @@ -1439,7 +1439,7 @@ static void fdctrl_handle_save(FDCtrl *fdctrl, int = direction) fdctrl->fifo[12] =3D fdctrl->pwrd; fdctrl->fifo[13] =3D 0; fdctrl->fifo[14] =3D 0; - fdctrl_set_fifo(fdctrl, 15, 1); + fdctrl_set_fifo(fdctrl, 15, 0); } =20 static void fdctrl_handle_readid(FDCtrl *fdctrl, int direction) @@ -1580,7 +1580,7 @@ static void fdctrl_handle_powerdown_mode(FDCtrl *fd= ctrl, int direction) { fdctrl->pwrd =3D fdctrl->fifo[1]; fdctrl->fifo[0] =3D fdctrl->fifo[1]; - fdctrl_set_fifo(fdctrl, 1, 1); + fdctrl_set_fifo(fdctrl, 1, 0); } =20 static void fdctrl_handle_option(FDCtrl *fdctrl, int direction) @@ -1599,7 +1599,7 @@ static void fdctrl_handle_drive_specification_comma= nd(FDCtrl *fdctrl, int direct fdctrl->fifo[0] =3D fdctrl->fifo[1]; fdctrl->fifo[2] =3D 0; fdctrl->fifo[3] =3D 0; - fdctrl_set_fifo(fdctrl, 4, 1); + fdctrl_set_fifo(fdctrl, 4, 0); } else { fdctrl_reset_fifo(fdctrl); } @@ -1607,7 +1607,7 @@ static void fdctrl_handle_drive_specification_comma= nd(FDCtrl *fdctrl, int direct /* ERROR */ fdctrl->fifo[0] =3D 0x80 | (cur_drv->head << 2) | GET_CUR_DRV(fdctrl); - fdctrl_set_fifo(fdctrl, 1, 1); + fdctrl_set_fifo(fdctrl, 1, 0); } } =20 --=20 1.7.6.5