From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S345N-0001rQ-IF for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:22:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S345G-00062Q-W2 for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:22:13 -0500 Received: from mail-pz0-f46.google.com ([209.85.210.46]:39512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S345G-000627-Mi for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:22:06 -0500 Received: by dajr28 with SMTP id r28so838089daj.33 for ; Thu, 01 Mar 2012 03:22:04 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 1 Mar 2012 12:21:42 +0100 Message-Id: <1330600908-16202-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, jcody@redhat.com, lcapitulino@redhat.com, fsimonce@redhat.com, eblake@redhat.com This implements all ingredients to establish mirrored writes. The drive-reopen command that is used to terminate mirrored writes is not included in this series. Tested with the following scenarios: a) mirror only 1) create base.qcow2 and start QEMU with it 2) Execute the following QMP command { "execute": "qmp_capabilities" } { "execute": "blockdev-transaction", "arguments": {'actions': [ { 'type': 'mirror', 'data' : { 'device': 'ide0-hd0', 'target': '/home/pbonzini/mirror.qcow2' } } ] } } { "execute": "cont" } 3) hibernate the guest (this requires an IDE disk and -cpu kvm64,-kvmclock) 4) restart the guest with mirror.qcow2 b) atomic snapshot+mirror 1) start QEMU with an existing image test.img 2) Execute the following QMP command { "execute": "qmp_capabilities" } { "execute": "blockdev-transaction", "arguments": {'actions': [ { 'type': 'snapshot', 'data' : { 'device': 'ide0-hd0', 'snapshot-file': '/home/pbonzini/base.qcow2' } }, { 'type': 'mirror', 'data' : { 'device': 'ide0-hd0', 'target': '/home/pbonzini/mirror.qcow2' } } ] } } { "execute": "cont" } 3) hibernate the guest (this requires an IDE disk and -cpu kvm64,-kvmclock) 4) check that mirror.qcow2 has test.img as the base 5) restart the guest with base.qcow2 6) restart the guest with mirror.qcow2 v1->v2: Removed wrong assertions in patches 3 and 6 Move new_image_file and other variables inside the while loop (Federico) Rename new_source_file to new_source (Federico) Fix image name in error message (Federico) Fixed documentation in qapi-schema.json (Federico) Fixed documentation and example in qmp-commands.hx (Eric) Added back AIO (Stefan), with fixes to cancellation Marcelo Tosatti (1): Add blkmirror block driver Paolo Bonzini (5): fix format name for backing file qapi: complete implementation of unions rename blockdev-group-snapshot-sync add reuse field add mirroring to blockdev-transaction Makefile.objs | 2 +- block/blkmirror.c | 239 +++++++++++++++++++++++++++++++++++++++++++++ blockdev.c | 114 ++++++++++++++-------- qapi-schema-test.json | 10 ++ qapi-schema.json | 51 ++++++++-- qmp-commands.hx | 68 +++++++++---- scripts/qapi-types.py | 5 + scripts/qapi-visit.py | 31 ++++++- test-qmp-input-visitor.c | 18 ++++ test-qmp-output-visitor.c | 34 +++++++ 10 files changed, 496 insertions(+), 76 deletions(-) create mode 100644 block/blkmirror.c -- 1.7.7.6