qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, vilanova@ac.upc.edu, aneesh.kumar@linux.vnet.ibm.com
Subject: [Qemu-devel] [RFC PATCH v5 02/14] trace: [tracetool] Do not rebuild event list in backend code
Date: Thu,  1 Mar 2012 18:55:28 +0530	[thread overview]
Message-ID: <1330608340-9515-3-git-send-email-harsh@linux.vnet.ibm.com> (raw)
In-Reply-To: <1330608340-9515-1-git-send-email-harsh@linux.vnet.ibm.com>

From: Lluís Vilanova <vilanova@ac.upc.edu>

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
---
 scripts/tracetool.py |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/scripts/tracetool.py b/scripts/tracetool.py
index 079ec7a..274fa70 100755
--- a/scripts/tracetool.py
+++ b/scripts/tracetool.py
@@ -257,8 +257,7 @@ def ust_c(events):
 #undef inline
 #undef wmb
 #include "trace.h"'''
-    eventlist = list(events)
-    for event in eventlist:
+    for event in events:
         argnames = event.argnames
         if event.argc > 0:
             argnames = ', ' + event.argnames
@@ -290,7 +289,7 @@ static void ust_%(name)s_probe(%(args)s)
     print '''
 static void __attribute__((constructor)) trace_init(void)
 {'''
-    for event in eventlist:
+    for event in events:
         print '    register_trace_ust_%(name)s(ust_%(name)s_probe);' % {
     'name': event.name
 }
@@ -435,13 +434,15 @@ class Event(object):
 # Generator that yields Event objects given a trace-events file object
 def read_events(fobj):
     event_num = 0
+    res = []
     for line in fobj:
         if not line.strip():
             continue
         if line.lstrip().startswith('#'):
 	    continue
-        yield Event(event_num, line)
+        res.append(Event(event_num, line))
         event_num += 1
+    return res
 
 binary = ""
 probeprefix = ""
-- 
1.7.1.1

  parent reply	other threads:[~2012-03-01 13:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-01 13:25 [Qemu-devel] [RFC PATCH v5 00/14] Tracing Improvements, Simpletrace v2 Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 01/14] Converting tracetool.sh to tracetool.py Harsh Prateek Bora
2012-03-01 13:25 ` Harsh Prateek Bora [this message]
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 03/14] trace: [tracetool] Simplify event line parsing Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 04/14] trace: [tracetool] Do not precompute the event number Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 05/14] trace: [tracetool] Add support for event properties Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 06/14] trace: [tracetool] Process the "disable" event property Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 07/14] trace: [tracetool] Rewrite event argument parsing Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 08/14] trace: [tracetool] Make format-specific code optional with access to events Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 09/14] trace: [tracetool] Automatically establish available backends and formats Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 10/14] trace: Provide a per-event status define for conditional compilation Harsh Prateek Bora
2012-03-12 15:25   ` Lluís Vilanova
2012-03-14  5:25     ` Harsh Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 11/14] trace: [tracetool] Add error-reporting functions Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 12/14] monitor: remove unused do_info_trace Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 13/14] Simpletrace v2: Handle var num of args, strings Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 14/14] scripts/simpltrace.py changes: Support simplettrace v2 Harsh Prateek Bora
2012-03-13 20:11 ` [Qemu-devel] [RFC PATCH v5 00/14] Tracing Improvements, Simpletrace v2 Lluís Vilanova
2012-03-14  5:36   ` Harsh Bora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330608340-9515-3-git-send-email-harsh@linux.vnet.ibm.com \
    --to=harsh@linux.vnet.ibm.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).