From: Federico Simoncelli <fsimonce@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com,
Federico Simoncelli <fsimonce@redhat.com>,
eblake@redhat.com
Subject: [Qemu-devel] [PATCH] add reopen to blockdev-transaction
Date: Thu, 1 Mar 2012 15:13:39 +0000 [thread overview]
Message-ID: <1330614819-26929-1-git-send-email-fsimonce@redhat.com> (raw)
Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
---
blockdev.c | 8 ++++++++
qapi-schema.json | 12 ++++++++++++
qmp-commands.hx | 6 +++++-
3 files changed, 25 insertions(+), 1 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 56da5c9..36fe07c 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -798,6 +798,14 @@ void qmp_blockdev_transaction(BlockdevActionList *dev_list,
dev_info->mirror->target);
break;
+ case BLOCKDEV_ACTION_KIND_REOPEN:
+ device = dev_info->reopen->device;
+ if (dev_info->format->has_format) {
+ format = dev_info->reopen->format;
+ }
+ new_source = g_strdup(dev_info->reopen->target);
+ break;
+
default:
abort();
}
diff --git a/qapi-schema.json b/qapi-schema.json
index b33875d..17f7548 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1145,6 +1145,17 @@
{ 'type': 'BlockdevMirror',
'data': { 'device': 'str', 'target': 'str', '*format': 'str',
'*reuse': 'bool' } }
+##
+# @BlockdevReopen
+#
+# @device: the name of the device to reopen.
+#
+# @target: the target of the new image.
+#
+# @format: #optional the format of the new image, default is 'qcow2'.
+##
+{ 'type': 'BlockdevReopen',
+ 'data': { 'device': 'str', 'target': 'str', '*format': 'str' } }
##
# @BlockdevAction
@@ -1156,6 +1167,7 @@
'data': {
'snapshot': 'BlockdevSnapshot',
'mirror': 'BlockdevMirror',
+ 'reopen': 'BlockdevReopen',
} }
##
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 50ac5a0..317c448 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -720,7 +720,7 @@ Arguments:
actions array:
- "type": the operation to perform. The only supported
- values are "snapshot" and "mirror". (json-string)
+ values are "snapshot", "mirror" and "reopen". (json-string)
- "data": a dictionary. The contents depend on the value
of "type". When "type" is "snapshot":
- "device": device name to snapshot (json-string)
@@ -734,6 +734,10 @@ actions array:
- "format": format of new image (json-string, optional)
- "reuse": whether QEMU should look for an existing image file
(json-bool, optional, default false)
+ When "type" is "reopen":
+ - "device": device name to reopen (json-string)
+ - "target": name of destination image file (json-string)
+ - "format": format of new image (json-string, optional)
Example:
--
1.7.1
next reply other threads:[~2012-03-01 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 15:13 Federico Simoncelli [this message]
2012-03-01 15:36 ` [Qemu-devel] [PATCH] add reopen to blockdev-transaction Paolo Bonzini
2012-03-01 16:23 ` Eric Blake
2012-03-01 16:52 ` Paolo Bonzini
2012-03-02 13:00 ` Kevin Wolf
2012-03-02 13:25 ` Paolo Bonzini
2012-03-02 13:38 ` Kevin Wolf
2012-03-02 13:08 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330614819-26929-1-git-send-email-fsimonce@redhat.com \
--to=fsimonce@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).