From: Wanpeng Li <liwp@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org, aliguori@us.ibm.com
Cc: liwp@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH] PCI Using macro definition instead of a simple digit
Date: Sat, 3 Mar 2012 20:38:42 +0800 [thread overview]
Message-ID: <1330778322-30749-1-git-send-email-liwp@linux.vnet.ibm.com> (raw)
PCI_CLASS_DISPLAY_VGA has already defined in hw/pci_ids.h, so use the
macro definition instead of a simple digit.
Signed-off-by: Wanpeng Li <liwp@linux.vnet.ibm.com>
---
hw/pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index fe71666..274d86d 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -1784,7 +1784,7 @@ static int pci_add_option_rom(PCIDevice *pdev, bool is_default_rom)
* for 0.11 compatibility.
*/
int class = pci_get_word(pdev->config + PCI_CLASS_DEVICE);
- if (class == 0x0300) {
+ if (class == PCI_CLASS_DISPLAY_VGA) {
rom_add_vga(pdev->romfile);
} else {
rom_add_option(pdev->romfile, -1);
--
1.7.5.4
next reply other threads:[~2012-03-03 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 12:38 Wanpeng Li [this message]
2012-03-03 19:48 ` [Qemu-devel] [PATCH] PCI Using macro definition instead of a simple digit Andreas Färber
-- strict thread matches above, loose matches on Subject: below --
2012-03-03 12:47 Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330778322-30749-1-git-send-email-liwp@linux.vnet.ibm.com \
--to=liwp@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).