From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49381)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1S4Ioj-0000YY-OB
	for qemu-devel@nongnu.org; Sun, 04 Mar 2012 16:18:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1S4IoP-00053v-MR
	for qemu-devel@nongnu.org; Sun, 04 Mar 2012 16:18:09 -0500
Received: from gate.crashing.org ([63.228.1.57]:41103)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1S4IoP-00053j-Dt
	for qemu-devel@nongnu.org; Sun, 04 Mar 2012 16:17:49 -0500
Message-ID: <1330895848.11728.81.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Mon, 05 Mar 2012 08:17:28 +1100
In-Reply-To: <4F539C4E.2090304@suse.de>
References: <1330043012-30556-1-git-send-email-david@gibson.dropbear.id.au>
	<1330043012-30556-7-git-send-email-david@gibson.dropbear.id.au>
	<4F4CC96B.6040003@redhat.com> <1330465707.11728.29.camel@pasglop>
	<4F5348CE.8070909@redhat.com> <1330861999.11728.79.camel@pasglop>
	<4F539C4E.2090304@suse.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 6/6] kvm: Fix dirty tracking with large
 kernel page size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>, anthony@codemonkey.ws, David Gibson <david@gibson.dropbear.id.au>

On Sun, 2012-03-04 at 17:46 +0100, Andreas F=C3=A4rber wrote:
> Except for ppcemb-softmmu (1k), which is irrelevant for KVM AFAIU.
>=20
> Maybe just add an assert and be done with it?

Well, my patch should work anyway, as long as getpagesize() returns a
higher power of two.

The case that wouldn't work (but also doesn't exist) is getpagesize() <
TARGET_PAGE_SIZE.

> For the record, I am hoping to get rid of some of those cpu.h defines
> in a later stage of QOM'ification.

Cheers,
Ben.