From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58073)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1S4IqB-0001U2-ND
	for qemu-devel@nongnu.org; Sun, 04 Mar 2012 16:19:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1S4Iq9-0005U1-U9
	for qemu-devel@nongnu.org; Sun, 04 Mar 2012 16:19:39 -0500
Received: from gate.crashing.org ([63.228.1.57]:41122)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1S4Iq9-0005Tp-Kv
	for qemu-devel@nongnu.org; Sun, 04 Mar 2012 16:19:37 -0500
Message-ID: <1330895957.11728.83.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Mon, 05 Mar 2012 08:19:17 +1100
In-Reply-To: <1D497AA3-7C51-49A4-AA1A-5A0194EC3EE9@suse.de>
References: <1330043012-30556-1-git-send-email-david@gibson.dropbear.id.au>
	<1330043012-30556-7-git-send-email-david@gibson.dropbear.id.au>
	<4F4CC96B.6040003@redhat.com> <1330465707.11728.29.camel@pasglop>
	<4F5348CE.8070909@redhat.com> <1330861999.11728.79.camel@pasglop>
	<4F539C4E.2090304@suse.de>
	<7C5C662C-6D69-459A-90EA-246596648796@suse.de>
	<4F53CEB0.7030406@suse.de>
	<2BF15430-E518-4949-ABB7-D1095DE40340@suse.de>
	<4F53D127.3030206@suse.de>
	<1D497AA3-7C51-49A4-AA1A-5A0194EC3EE9@suse.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 6/6] kvm: Fix dirty tracking with large
 kernel page size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>, "anthony@codemonkey.ws" <anthony@codemonkey.ws>, Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>, David Gibson <david@gibson.dropbear.id.au>

On Sun, 2012-03-04 at 21:59 +0100, Alexander Graf wrote:
> >>> g_assert(TARGET_PAGE_SIZE <= getpagesize())
> >>> 
> >>> Just declare the above case as unsupported and abort if we
> encounter it.
> >> 
> >> What I'm trying to tell you is that it's the default case on book3s
> ppc! ;)
> > 
> > Exactly, which is why I'm saying just ignore the weird embedded
> case. :)
> 
> Ugh. Sorry, apparently I can't read :). So you're saying 'break for
> ppcemb'. Hrm. Not sure that'd be all that great for 440, since there
> host pagesize is still 4k, but T_P_S is 1k.

No, Alex, you are reading Andreas assert backward :-)

What he suggests is "break if TARGET_PAGE_SIZE > getpagesize()" which
currently cannot happen. Even embedded 1k TARGET_PAGE_SIZE is fine. It's
getpagesize() 1k that wouldn't be but it also never happens.

Cheers,
Ben.