From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v2 2/5] omap: switch omap_lpg to vm_clock
Date: Mon, 5 Mar 2012 10:08:12 +0100 [thread overview]
Message-ID: <1330938495-30573-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1330938495-30573-1-git-send-email-pbonzini@redhat.com>
The output of the pulse generator needs to be deterministic when
running in -icount mode, and to remain constant whenever the VM is
stopped. So the right clock to use is vm_clock.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/omap1.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/omap1.c b/hw/omap1.c
index 1aa5f23..d19049a 100644
--- a/hw/omap1.c
+++ b/hw/omap1.c
@@ -3497,9 +3497,9 @@ static void omap_lpg_tick(void *opaque)
struct omap_lpg_s *s = opaque;
if (s->cycle)
- qemu_mod_timer(s->tm, qemu_get_clock_ms(rt_clock) + s->period - s->on);
+ qemu_mod_timer(s->tm, qemu_get_clock_ms(vm_clock) + s->period - s->on);
else
- qemu_mod_timer(s->tm, qemu_get_clock_ms(rt_clock) + s->on);
+ qemu_mod_timer(s->tm, qemu_get_clock_ms(vm_clock) + s->on);
s->cycle = !s->cycle;
printf("%s: LED is %s\n", __FUNCTION__, s->cycle ? "on" : "off");
@@ -3617,7 +3617,7 @@ static struct omap_lpg_s *omap_lpg_init(MemoryRegion *system_memory,
struct omap_lpg_s *s = (struct omap_lpg_s *)
g_malloc0(sizeof(struct omap_lpg_s));
- s->tm = qemu_new_timer_ms(rt_clock, omap_lpg_tick, s);
+ s->tm = qemu_new_timer_ms(vm_clock, omap_lpg_tick, s);
omap_lpg_reset(s);
--
1.7.7.6
next prev parent reply other threads:[~2012-03-05 9:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 9:08 [Qemu-devel] [PATCH v2 0/5] Make rt_clock usage configurable for ARM devices Paolo Bonzini
2012-03-05 9:08 ` [Qemu-devel] [PATCH v2 1/5] rtc: add -rtc clock=rt Paolo Bonzini
2012-03-05 9:08 ` Paolo Bonzini [this message]
2012-03-05 9:08 ` [Qemu-devel] [PATCH v2 3/5] arm: switch real-time clocks to rtc_clock Paolo Bonzini
2012-03-05 9:08 ` [Qemu-devel] [PATCH v2 4/5] pl031: rearm alarm timer upon load Paolo Bonzini
2012-03-05 9:08 ` [Qemu-devel] [PATCH v2 5/5] pl031: switch clock base to rtc_clock Paolo Bonzini
2012-03-05 14:05 ` [Qemu-devel] [PATCH v2 0/5] Make rt_clock usage configurable for ARM devices Peter Maydell
2012-03-13 10:46 ` Paolo Bonzini
2012-03-27 17:07 ` Paolo Bonzini
2012-03-27 17:24 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330938495-30573-3-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).