qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, uobergfe@redhat.com, owasserm@redhat.com,
	armbru@redhat.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH 2/3] virtio-balloon: note optional features
Date: Tue,  6 Mar 2012 13:22:06 +0100	[thread overview]
Message-ID: <1331036527-7651-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1331036527-7651-1-git-send-email-pbonzini@redhat.com>

It is not a problem if the destination does not have
VIRTIO_BALLOON_F_MUST_TELL_HOST.  In that case, the guest
will simply do useless virtqueue traffic, but the destination
does not have a problem.

(In fact, it _is_ a problem if the destination has
VIRTIO_BALLOON_F_MUST_TELL_HOST but the source does not.
The feature bit should have been backwards!  Luckily,
our implementation is free from this problem).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/virtio-balloon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index 0ade8b0..d10df2e 100644
--- a/hw/virtio-balloon.c
+++ b/hw/virtio-balloon.c
@@ -216,7 +216,7 @@ static int virtio_balloon_load(QEMUFile *f, void *opaque, int version_id)
     if (version_id != 1)
         return -EINVAL;
 
-    ret = virtio_load(&s->vdev, f, 0);
+    ret = virtio_load(&s->vdev, f, VIRTIO_BALLOON_F_MUST_TELL_HOST);
     if (ret) {
         return ret;
     }
-- 
1.7.7.6

  parent reply	other threads:[~2012-03-06 12:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06 12:22 [Qemu-devel] [PATCH 0/3] Make virtio_load permissive when possible Paolo Bonzini
2012-03-06 12:22 ` [Qemu-devel] [PATCH 1/3] virtio: let devices be permissive on enabled features Paolo Bonzini
2012-03-06 13:33   ` Michael S. Tsirkin
2012-03-06 13:57     ` Paolo Bonzini
2012-03-06 14:22       ` Orit Wasserman
2012-03-06 12:22 ` Paolo Bonzini [this message]
2012-03-06 14:55   ` [Qemu-devel] [PATCH 2/3] virtio-balloon: note optional features Michael S. Tsirkin
2012-03-06 14:59     ` Paolo Bonzini
2012-03-06 15:08       ` Michael S. Tsirkin
2012-03-06 15:13         ` Paolo Bonzini
2012-03-06 12:22 ` [Qemu-devel] [PATCH 3/3] virtio-blk: " Paolo Bonzini
2012-03-06 14:53   ` Michael S. Tsirkin
2012-03-06 15:58     ` Paolo Bonzini
2012-03-06 17:03   ` Anthony Liguori
2012-03-06 17:12     ` Paolo Bonzini
2012-03-06 17:15       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331036527-7651-3-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=mst@redhat.com \
    --cc=owasserm@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=uobergfe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).