From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4tPc-0004qa-G0 for qemu-devel@nongnu.org; Tue, 06 Mar 2012 07:22:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4tPW-0004bJ-7E for qemu-devel@nongnu.org; Tue, 06 Mar 2012 07:22:40 -0500 Received: from mail-tul01m020-f173.google.com ([209.85.214.173]:51194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4tPW-0004ZJ-08 for qemu-devel@nongnu.org; Tue, 06 Mar 2012 07:22:34 -0500 Received: by mail-tul01m020-f173.google.com with SMTP id up6so6817206obb.4 for ; Tue, 06 Mar 2012 04:22:33 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 6 Mar 2012 13:22:07 +0100 Message-Id: <1331036527-7651-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1331036527-7651-1-git-send-email-pbonzini@redhat.com> References: <1331036527-7651-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 3/3] virtio-blk: note optional features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com, uobergfe@redhat.com, owasserm@redhat.com, armbru@redhat.com, mst@redhat.com The guest must already be prepared to see SG_IO support disappear from under its feet, for example if migration refers to a block device on the source and file-based storage on the destination; or more likely, if the source kernel allows (gasp) SG_IO on a partition and the destination does not. So, we can migrate safely even if the source had VIRTIO_BLK_F_SCSI and the destination does not. Signed-off-by: Paolo Bonzini --- hw/virtio-blk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index c95f8fc..9a4158a 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -542,7 +542,7 @@ static int virtio_blk_load(QEMUFile *f, void *opaque, int version_id) if (version_id != 2) return -EINVAL; - ret = virtio_load(&s->vdev, f, 0); + ret = virtio_load(&s->vdev, f, VIRTIO_BLK_F_SCSI); if (ret) { return ret; } -- 1.7.7.6