From: "Benoît Canet" <benoit.canet@gmail.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, "Benoît Canet" <benoit.canet@gmail.com>,
stefanha@linux.vnet.ibm.com, wolf@redhat.com
Subject: [Qemu-devel] [RFC PATCH 09/10] qed: honor BDRV_O_INCOMING for incoming live migration
Date: Tue, 6 Mar 2012 18:32:28 +0100 [thread overview]
Message-ID: <1331055149-10982-10-git-send-email-benoit.canet@gmail.com> (raw)
In-Reply-To: <1331055149-10982-1-git-send-email-benoit.canet@gmail.com>
>From original commit is Patchwork-id: 31108 by
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
"The QED image format includes a file header bit to mark images dirty.
QED normally checks dirty images on open and fixes inconsistent
metadata. This is undesirable during live migration since the dirty bit
may be set if the source host is modifying the image file. The check
should be postponed until migration completes.
Skip operations that modify the image file if the BDRV_O_INCOMING flag
is set."
Signed-off-by: Benoit Canet <benoit.canet@gmail.com>
---
block/qed.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index f6300af..4bfda24 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -378,7 +378,8 @@ static int check_image_if_needed(BlockDriverState *bs)
* potentially inconsistent images to be opened read-only. This can
* aid data recovery from an otherwise inconsistent image.
*/
- if (!bdrv_is_read_only(bs->file)) {
+ if (!bdrv_is_read_only(bs->file) &&
+ !(bs->open_flags & BDRV_O_INCOMING)) {
BdrvCheckResult result = {0};
ret = qed_check(s, &result, true);
@@ -481,7 +482,7 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags)
* feature is no longer valid.
*/
if ((s->header.autoclear_features & ~QED_AUTOCLEAR_FEATURE_MASK) != 0 &&
- !bdrv_is_read_only(bs->file)) {
+ !bdrv_is_read_only(bs->file) && !(flags & BDRV_O_INCOMING)) {
s->header.autoclear_features &= QED_AUTOCLEAR_FEATURE_MASK;
ret = qed_write_header_sync(s);
--
1.7.7.6
next prev parent reply other threads:[~2012-03-06 17:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 17:32 [Qemu-devel] [RFC PATCH 00/10] make qed and live migration usage safe Benoît Canet
2012-03-06 17:32 ` [Qemu-devel] [RFC PATCH 01/10] block: Add new BDRV_O_INCOMING flag to notice incoming live migration Benoît Canet
2012-03-06 17:32 ` [Qemu-devel] [RFC PATCH 02/10] block: add a function to set " Benoît Canet
2012-03-20 15:57 ` Stefan Hajnoczi
2012-03-06 17:32 ` [Qemu-devel] [RFC PATCH 03/10] block: add a function to clear " Benoît Canet
2012-03-06 17:32 ` [Qemu-devel] [RFC PATCH 04/10] block: rename *_invalidate_cache_* to *_post_incoming_migration_* Benoît Canet
2012-03-06 17:32 ` [Qemu-devel] [RFC PATCH 05/10] migration: inform the block layer of incoming live status Benoît Canet
2012-03-06 17:32 ` [Qemu-devel] [RFC PATCH 06/10] block: open images with BDRV_O_INCOMING on incoming live migration Benoît Canet
2012-03-06 17:32 ` [Qemu-devel] [RFC PATCH 07/10] qed: extract image checking into check_image_if_needed Benoît Canet
2012-03-06 17:32 ` [Qemu-devel] [RFC PATCH 08/10] qed: add bdrv_post_incoming_migration operation checking the image Benoît Canet
2012-03-20 15:42 ` Stefan Hajnoczi
2012-03-20 15:52 ` Benoît Canet
2012-03-20 16:05 ` Stefan Hajnoczi
2012-03-06 17:32 ` Benoît Canet [this message]
2012-03-06 17:32 ` [Qemu-devel] [RFC PATCH 10/10] qed: remove incoming live migration blocker Benoît Canet
2012-03-06 20:10 ` [Qemu-devel] [RFC PATCH 00/10] make qed and live migration usage safe Benoît Canet
2012-03-16 12:40 ` Benoît Canet
2012-03-20 15:47 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331055149-10982-10-git-send-email-benoit.canet@gmail.com \
--to=benoit.canet@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=wolf@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).