From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 06/13] Fix sign of sscanf format specifiers
Date: Wed, 7 Mar 2012 12:44:40 +0000 [thread overview]
Message-ID: <1331124287-6327-7-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1331124287-6327-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: Stefan Weil <sw@weilnetz.de>
All values read by sscanf are unsigned, so replace %d by %u.
This signed / unsigned mismatch was detected by splint.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
cursor.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/cursor.c b/cursor.c
index efc5917..76e262c 100644
--- a/cursor.c
+++ b/cursor.c
@@ -15,7 +15,8 @@ static QEMUCursor *cursor_parse_xpm(const char *xpm[])
uint8_t idx;
/* parse header line: width, height, #colors, #chars */
- if (sscanf(xpm[line], "%d %d %d %d", &width, &height, &colors, &chars) != 4) {
+ if (sscanf(xpm[line], "%u %u %u %u",
+ &width, &height, &colors, &chars) != 4) {
fprintf(stderr, "%s: header parse error: \"%s\"\n",
__FUNCTION__, xpm[line]);
return NULL;
--
1.7.9.1
next prev parent reply other threads:[~2012-03-07 12:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 12:44 [Qemu-devel] [PULL 00/13] Trivial patches for 25 February to 7 March 2012 Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 01/13] ppc: Add missing 'static' to spin_rw_ops Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 02/13] sh7750: Remove redundant 'struct' from MemoryRegionOps Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 03/13] qom: Fix spelling in documentation Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 04/13] qmp: Fix spelling fourty -> forty Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 05/13] block/vmdk: Fix warning from splint (comparision of unsigned value) Stefan Hajnoczi
2012-03-07 12:44 ` Stefan Hajnoczi [this message]
2012-03-07 12:44 ` [Qemu-devel] [PATCH 07/13] vnc: Fix packed boolean struct members Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 08/13] libcacard: Use format specifier %u instead of %d for unsigned values Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 09/13] vnc: Add break statement Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 10/13] Spelling fixes in comments (it's -> its) Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 11/13] libcacard: Spelling and grammar fixes in documentation Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 12/13] osdep: Remove local definition of macro offsetof Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 13/13] configure: Quote the configure args printed in config.log Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331124287-6327-7-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).