From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 07/13] vnc: Fix packed boolean struct members
Date: Wed, 7 Mar 2012 12:44:41 +0000 [thread overview]
Message-ID: <1331124287-6327-8-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1331124287-6327-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: Stefan Weil <sw@weilnetz.de>
This patch fixes warnings reported by splint:
For variables which are packed in a single bit, a signed data type
like 'int' does not make much sense.
There is no obvious reason why the two values should be packed,
so I removed the packing and changed the data type to bool
because both are used as boolean values.
Cc: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
ui/vnc-auth-sasl.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/vnc-auth-sasl.h b/ui/vnc-auth-sasl.h
index fd9b18a..ee243a9 100644
--- a/ui/vnc-auth-sasl.h
+++ b/ui/vnc-auth-sasl.h
@@ -37,9 +37,9 @@ typedef struct VncDisplaySASL VncDisplaySASL;
struct VncStateSASL {
sasl_conn_t *conn;
/* If we want to negotiate an SSF layer with client */
- int wantSSF :1;
+ bool wantSSF;
/* If we are now running the SSF layer */
- int runSSF :1;
+ bool runSSF;
/*
* If this is non-zero, then wait for that many bytes
* to be written plain, before switching to SSF encoding
--
1.7.9.1
next prev parent reply other threads:[~2012-03-07 12:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 12:44 [Qemu-devel] [PULL 00/13] Trivial patches for 25 February to 7 March 2012 Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 01/13] ppc: Add missing 'static' to spin_rw_ops Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 02/13] sh7750: Remove redundant 'struct' from MemoryRegionOps Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 03/13] qom: Fix spelling in documentation Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 04/13] qmp: Fix spelling fourty -> forty Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 05/13] block/vmdk: Fix warning from splint (comparision of unsigned value) Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 06/13] Fix sign of sscanf format specifiers Stefan Hajnoczi
2012-03-07 12:44 ` Stefan Hajnoczi [this message]
2012-03-07 12:44 ` [Qemu-devel] [PATCH 08/13] libcacard: Use format specifier %u instead of %d for unsigned values Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 09/13] vnc: Add break statement Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 10/13] Spelling fixes in comments (it's -> its) Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 11/13] libcacard: Spelling and grammar fixes in documentation Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 12/13] osdep: Remove local definition of macro offsetof Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 13/13] configure: Quote the configure args printed in config.log Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331124287-6327-8-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).