From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5GGK-000687-Ku for qemu-devel@nongnu.org; Wed, 07 Mar 2012 07:46:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5GFs-0002pr-9g for qemu-devel@nongnu.org; Wed, 07 Mar 2012 07:46:36 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:59386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5GFs-0002ow-0j for qemu-devel@nongnu.org; Wed, 07 Mar 2012 07:46:08 -0500 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 7 Mar 2012 12:46:04 -0000 Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q27Ck1g12642002 for ; Wed, 7 Mar 2012 12:46:01 GMT Received: from d06av08.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q27Ck1xM009835 for ; Wed, 7 Mar 2012 05:46:01 -0700 From: Stefan Hajnoczi Date: Wed, 7 Mar 2012 12:44:41 +0000 Message-Id: <1331124287-6327-8-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1331124287-6327-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1331124287-6327-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 07/13] vnc: Fix packed boolean struct members List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Weil , qemu-devel@nongnu.org, Stefan Hajnoczi From: Stefan Weil This patch fixes warnings reported by splint: For variables which are packed in a single bit, a signed data type like 'int' does not make much sense. There is no obvious reason why the two values should be packed, so I removed the packing and changed the data type to bool because both are used as boolean values. Cc: Anthony Liguori Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- ui/vnc-auth-sasl.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/vnc-auth-sasl.h b/ui/vnc-auth-sasl.h index fd9b18a..ee243a9 100644 --- a/ui/vnc-auth-sasl.h +++ b/ui/vnc-auth-sasl.h @@ -37,9 +37,9 @@ typedef struct VncDisplaySASL VncDisplaySASL; struct VncStateSASL { sasl_conn_t *conn; /* If we want to negotiate an SSF layer with client */ - int wantSSF :1; + bool wantSSF; /* If we are now running the SSF layer */ - int runSSF :1; + bool runSSF; /* * If this is non-zero, then wait for that many bytes * to be written plain, before switching to SSF encoding -- 1.7.9.1