From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 08/13] libcacard: Use format specifier %u instead of %d for unsigned values
Date: Wed, 7 Mar 2012 12:44:42 +0000 [thread overview]
Message-ID: <1331124287-6327-9-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1331124287-6327-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: Stefan Weil <sw@weilnetz.de>
splint reported warnings for those code statements.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
libcacard/vscclient.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index e317a25..0adae13 100644
--- a/libcacard/vscclient.c
+++ b/libcacard/vscclient.c
@@ -66,7 +66,7 @@ send_msg(
qemu_mutex_lock(&write_lock);
if (verbose > 10) {
- printf("sending type=%d id=%d, len =%d (0x%x)\n",
+ printf("sending type=%d id=%u, len =%u (0x%x)\n",
type, reader_id, length, length);
}
@@ -167,7 +167,7 @@ event_thread(void *arg)
case VEVENT_READER_REMOVE:
/* future, tell qemu that an old CCID reader has been removed */
if (verbose > 10) {
- printf(" READER REMOVE: %d\n", reader_id);
+ printf(" READER REMOVE: %u\n", reader_id);
}
send_msg(VSC_ReaderRemove, reader_id, NULL, 0);
break;
@@ -178,7 +178,7 @@ event_thread(void *arg)
vreader_power_on(event->reader, atr, &atr_len);
/* ATR call functions as a Card Insert event */
if (verbose > 10) {
- printf(" CARD INSERT %d: ", reader_id);
+ printf(" CARD INSERT %u: ", reader_id);
print_byte_array(atr, atr_len);
}
send_msg(VSC_ATR, reader_id, atr, atr_len);
@@ -186,7 +186,7 @@ event_thread(void *arg)
case VEVENT_CARD_REMOVE:
/* Card removed */
if (verbose > 10) {
- printf(" CARD REMOVE %d:\n", reader_id);
+ printf(" CARD REMOVE %u:\n", reader_id);
}
send_msg(VSC_CardRemove, reader_id, NULL, 0);
break;
@@ -256,7 +256,7 @@ do_command(void)
reader ? vreader_get_name(reader)
: "invalid reader", error);
} else {
- printf("no reader by id %d found\n", reader_id);
+ printf("no reader by id %u found\n", reader_id);
}
} else if (strncmp(string, "remove", 6) == 0) {
if (string[6] == ' ') {
@@ -269,7 +269,7 @@ do_command(void)
reader ? vreader_get_name(reader)
: "invalid reader", error);
} else {
- printf("no reader by id %d found\n", reader_id);
+ printf("no reader by id %u found\n", reader_id);
}
} else if (strncmp(string, "select", 6) == 0) {
if (string[6] == ' ') {
@@ -280,11 +280,11 @@ do_command(void)
reader = vreader_get_reader_by_id(reader_id);
}
if (reader) {
- printf("Selecting reader %d, %s\n", reader_id,
+ printf("Selecting reader %u, %s\n", reader_id,
vreader_get_name(reader));
default_reader_id = reader_id;
} else {
- printf("Reader with id %d not found\n", reader_id);
+ printf("Reader with id %u not found\n", reader_id);
}
} else if (strncmp(string, "debug", 5) == 0) {
if (string[5] == ' ') {
@@ -303,7 +303,7 @@ do_command(void)
if (reader_id == -1) {
continue;
}
- printf("%3d %s %s\n", reader_id,
+ printf("%3u %s %s\n", reader_id,
vreader_card_is_present(reader) == VREADER_OK ?
"CARD_PRESENT" : " ",
vreader_get_name(reader));
@@ -563,7 +563,7 @@ main(
mhHeader.reader_id = ntohl(mhHeader.reader_id);
mhHeader.length = ntohl(mhHeader.length);
if (verbose) {
- printf("Header: type=%d, reader_id=%d length=%d (0x%x)\n",
+ printf("Header: type=%d, reader_id=%u length=%d (0x%x)\n",
mhHeader.type, mhHeader.reader_id, mhHeader.length,
mhHeader.length);
}
--
1.7.9.1
next prev parent reply other threads:[~2012-03-07 12:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 12:44 [Qemu-devel] [PULL 00/13] Trivial patches for 25 February to 7 March 2012 Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 01/13] ppc: Add missing 'static' to spin_rw_ops Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 02/13] sh7750: Remove redundant 'struct' from MemoryRegionOps Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 03/13] qom: Fix spelling in documentation Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 04/13] qmp: Fix spelling fourty -> forty Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 05/13] block/vmdk: Fix warning from splint (comparision of unsigned value) Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 06/13] Fix sign of sscanf format specifiers Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 07/13] vnc: Fix packed boolean struct members Stefan Hajnoczi
2012-03-07 12:44 ` Stefan Hajnoczi [this message]
2012-03-07 12:44 ` [Qemu-devel] [PATCH 09/13] vnc: Add break statement Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 10/13] Spelling fixes in comments (it's -> its) Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 11/13] libcacard: Spelling and grammar fixes in documentation Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 12/13] osdep: Remove local definition of macro offsetof Stefan Hajnoczi
2012-03-07 12:44 ` [Qemu-devel] [PATCH 13/13] configure: Quote the configure args printed in config.log Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331124287-6327-9-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).