qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 20/20] xhci: fix port status
Date: Wed,  7 Mar 2012 14:05:20 +0100	[thread overview]
Message-ID: <1331125520-13467-21-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1331125520-13467-1-git-send-email-kraxel@redhat.com>

Don't signal port status change if the usb device isn't in attached
state.  Happens with usb-host devices with the pass-through device
being plugged out at the host.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb-xhci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/usb-xhci.c b/hw/usb-xhci.c
index 8305489..e8f1b6e 100644
--- a/hw/usb-xhci.c
+++ b/hw/usb-xhci.c
@@ -2279,7 +2279,7 @@ static void xhci_update_port(XHCIState *xhci, XHCIPort *port, int is_detach)
     int nr = port->port.index + 1;
 
     port->portsc = PORTSC_PP;
-    if (port->port.dev && !is_detach) {
+    if (port->port.dev && port->port.dev->attached && !is_detach) {
         port->portsc |= PORTSC_CCS;
         switch (port->port.dev->speed) {
         case USB_SPEED_LOW:
-- 
1.7.1

  parent reply	other threads:[~2012-03-07 13:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 13:05 [Qemu-devel] [PULL 00/20] usb patch queue Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 01/20] usb-redir: Set ep type and interface Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 02/20] usb-ehci: Never follow table entries with the T-bit set Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 03/20] usb-ehci: split our qh queue into async and periodic queues Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 04/20] usb-ehci: always call ehci_queues_rip_unused for period queues Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 05/20] usb-ehci: Drop cached qhs when the doorbell gets rung Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 06/20] usb-ehci: Rip the queues when the async or period schedule is halted Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 07/20] usb-ehci: Any packet completion except for NAK should set the interrupt Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 08/20] usb-ehci: Fix cerr tracking Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 09/20] usb-ehci: Remove dead nakcnt code Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 10/20] usb-ehci: Fix and simplify nakcnt handling Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 11/20] usb-ehci: Cleanup itd error handling Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 12/20] usb: return BABBLE rather then NAK when we receive too much data Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 13/20] usb: add USB_RET_IOERROR Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 14/20] uhci_fill_queue: zap debug printf Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 15/20] usb: queue can have async packets Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 16/20] usb: add pipelining option to usb endpoints Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 17/20] usb-host: enable pipelineing for bulk endpoints Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 18/20] usb: add shortcut for control transfers Gerd Hoffmann
2012-03-07 13:05 ` [Qemu-devel] [PATCH 19/20] xhci: fix control xfers Gerd Hoffmann
2012-03-07 13:05 ` Gerd Hoffmann [this message]
2012-03-09 19:17 ` [Qemu-devel] [PULL 00/20] usb patch queue Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331125520-13467-21-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).