From: David Gibson <david@gibson.dropbear.id.au>
To: anthony@codemonkey.ws
Cc: David Gibson <david@gibson.dropbear.id.au>,
qemu-devel@nongnu.org, Gerd Hoffman <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd
Date: Thu, 8 Mar 2012 11:41:10 +1100 [thread overview]
Message-ID: <1331167272-9800-3-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1331167272-9800-1-git-send-email-david@gibson.dropbear.id.au>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This fixes a broken endian assumption in an assertion in usb-msd.
Cc: Gerd Hoffman <kraxel@redhat.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/usb-msd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/usb-msd.c b/hw/usb-msd.c
index c6f08a0..c18e76d 100644
--- a/hw/usb-msd.c
+++ b/hw/usb-msd.c
@@ -195,7 +195,7 @@ static void usb_msd_send_status(MSDState *s, USBPacket *p)
DPRINTF("Command status %d tag 0x%x, len %zd\n",
s->csw.status, s->csw.tag, p->iov.size);
- assert(s->csw.sig == 0x53425355);
+ assert(s->csw.sig == cpu_to_le32(0x53425355));
len = MIN(sizeof(s->csw), p->iov.size);
usb_packet_copy(p, &s->csw, len);
memset(&s->csw, 0, sizeof(s->csw));
--
1.7.9.1
next prev parent reply other threads:[~2012-03-08 0:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[0/4] RESEND: Outstanding bugfixes and cleanups>
2012-03-08 0:41 ` [Qemu-devel] (no subject) David Gibson
2012-03-08 0:41 ` [Qemu-devel] [PATCH 1/4] kvm: Comparison with ioctl number macros needs to be unsigned David Gibson
2012-03-12 22:13 ` Alexander Graf
2012-03-08 0:41 ` David Gibson [this message]
2012-03-09 12:46 ` [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd Gerd Hoffmann
2012-03-13 4:22 ` Benjamin Herrenschmidt
2012-03-13 9:57 ` Gerd Hoffmann
2012-03-13 10:43 ` Benjamin Herrenschmidt
2012-03-13 10:44 ` David Gibson
2012-03-08 0:41 ` [Qemu-devel] [PATCH 3/4] kvm: Fix dirty tracking with large kernel page size David Gibson
2012-03-08 0:41 ` [Qemu-devel] [PATCH 4/4] pci: Factor out bounds checking on config space accesses David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331167272-9800-3-git-send-email-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).