From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5RQO-00017D-Bs for qemu-devel@nongnu.org; Wed, 07 Mar 2012 19:41:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5RQ3-0001XQ-3w for qemu-devel@nongnu.org; Wed, 07 Mar 2012 19:41:43 -0500 Received: from ozlabs.org ([203.10.76.45]:49624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5RQ2-0001Wz-Mz for qemu-devel@nongnu.org; Wed, 07 Mar 2012 19:41:23 -0500 From: David Gibson Date: Thu, 8 Mar 2012 11:41:10 +1100 Message-Id: <1331167272-9800-3-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1331167272-9800-1-git-send-email-david@gibson.dropbear.id.au> References: <[0/4] RESEND: Outstanding bugfixes and cleanups> <1331167272-9800-1-git-send-email-david@gibson.dropbear.id.au> Subject: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: David Gibson , qemu-devel@nongnu.org, Gerd Hoffman From: Benjamin Herrenschmidt This fixes a broken endian assumption in an assertion in usb-msd. Cc: Gerd Hoffman Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- hw/usb-msd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-msd.c b/hw/usb-msd.c index c6f08a0..c18e76d 100644 --- a/hw/usb-msd.c +++ b/hw/usb-msd.c @@ -195,7 +195,7 @@ static void usb_msd_send_status(MSDState *s, USBPacket *p) DPRINTF("Command status %d tag 0x%x, len %zd\n", s->csw.status, s->csw.tag, p->iov.size); - assert(s->csw.sig == 0x53425355); + assert(s->csw.sig == cpu_to_le32(0x53425355)); len = MIN(sizeof(s->csw), p->iov.size); usb_packet_copy(p, &s->csw, len); memset(&s->csw, 0, sizeof(s->csw)); -- 1.7.9.1