From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5aRV-0006xa-Pb for qemu-devel@nongnu.org; Thu, 08 Mar 2012 05:19:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5aRP-00087Z-5s for qemu-devel@nongnu.org; Thu, 08 Mar 2012 05:19:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5aRO-00085e-UH for qemu-devel@nongnu.org; Thu, 08 Mar 2012 05:19:23 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q28AJLsn017385 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 8 Mar 2012 05:19:21 -0500 From: Gerd Hoffmann Date: Thu, 8 Mar 2012 11:19:19 +0100 Message-Id: <1331201959-24133-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH] implement vnc_dpy_setdata List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann The comment is wrong, we have to do something in the setdata callback. Changing the framebuffer backing storage (happens when the guest pans the display) renders the whole screen content invalid. Trigger #1: cirrus vga + 32bit linux guest + vesafb with ypan enabled. Trigger #2: std vga + http://patchwork.ozlabs.org/patch/145479/ Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 8ee39bc..bdec33a 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1936,7 +1936,10 @@ static void pixel_format_message (VncState *vs) { static void vnc_dpy_setdata(DisplayState *ds) { - /* We don't have to do anything */ + VncDisplay *vd = ds->opaque; + + *(vd->guest.ds) = *(ds->surface); + vnc_dpy_update(ds, 0, 0, ds_get_width(ds), ds_get_height(ds)); } static void vnc_colordepth(VncState *vs) -- 1.7.1