From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 07/11] vnc: Add break statement
Date: Thu, 8 Mar 2012 15:37:17 +0000 [thread overview]
Message-ID: <1331221041-4710-8-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1331221041-4710-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: Stefan Weil <sw@weilnetz.de>
This was not a bug, but it is not common practice to omit the break statement
from the last case statement before an empty default case.
Any change of the default case would introduce a bug.
This was reported as a warning by splint.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
ui/vnc-enc-hextile-template.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/ui/vnc-enc-hextile-template.h b/ui/vnc-enc-hextile-template.h
index b9f9f5e..a7310e1 100644
--- a/ui/vnc-enc-hextile-template.h
+++ b/ui/vnc-enc-hextile-template.h
@@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs,
/* we really don't have to invalidate either the bg or fg
but we've lost the old values. oh well. */
}
+ break;
default:
break;
}
--
1.7.9.1
next prev parent reply other threads:[~2012-03-08 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 15:37 [Qemu-devel] [PULL v2 00/11] Trivial patches for 25 February to 7 March 2012 Stefan Hajnoczi
2012-03-08 15:37 ` [Qemu-devel] [PATCH 01/11] sh7750: Remove redundant 'struct' from MemoryRegionOps Stefan Hajnoczi
2012-03-08 15:37 ` [Qemu-devel] [PATCH 02/11] qom: Fix spelling in documentation Stefan Hajnoczi
2012-03-08 15:37 ` [Qemu-devel] [PATCH 03/11] qmp: Fix spelling fourty -> forty Stefan Hajnoczi
2012-03-08 15:37 ` [Qemu-devel] [PATCH 04/11] block/vmdk: Fix warning from splint (comparision of unsigned value) Stefan Hajnoczi
2012-03-08 15:37 ` [Qemu-devel] [PATCH 05/11] Fix sign of sscanf format specifiers Stefan Hajnoczi
2012-03-08 15:37 ` [Qemu-devel] [PATCH 06/11] libcacard: Use format specifier %u instead of %d for unsigned values Stefan Hajnoczi
2012-03-08 15:37 ` Stefan Hajnoczi [this message]
2012-03-08 15:37 ` [Qemu-devel] [PATCH 08/11] Spelling fixes in comments (it's -> its) Stefan Hajnoczi
2012-03-08 15:37 ` [Qemu-devel] [PATCH 09/11] libcacard: Spelling and grammar fixes in documentation Stefan Hajnoczi
2012-03-08 15:37 ` [Qemu-devel] [PATCH 10/11] osdep: Remove local definition of macro offsetof Stefan Hajnoczi
2012-03-08 15:37 ` [Qemu-devel] [PATCH 11/11] configure: Quote the configure args printed in config.log Stefan Hajnoczi
2012-03-09 19:18 ` [Qemu-devel] [PULL v2 00/11] Trivial patches for 25 February to 7 March 2012 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331221041-4710-8-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).