From: "Crístian Viana" <vianac@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, agl@us.ibm.com
Subject: [Qemu-devel] QEmu: support disk filenames with comma
Date: Fri, 9 Mar 2012 13:02:14 -0300 [thread overview]
Message-ID: <1331308936-30042-1-git-send-email-vianac@linux.vnet.ibm.com> (raw)
Hi!
This patch fixes RHBZ #801036 adding support to filenames with comma using QEmu. As this is my first patch to libvirt, I'm not completely sure if I should have also changed other parts of the code, or if I have used the wrong memory allocation functions/macros, or if I shouldn't have created a separate commit to add my name to the AUTHORS file... :-)
I also need to make it clear that this patch only fixes the problem in the "libvirt data -> QEmu args" way (e.g., when QEmu reads an XML file to start QEmu, or when using virsh domxml-to-native). The other way, "QEmu args -> libvirt data" is *not* implemented (e.g., virsh domxml-from-native). I would like to know if I'm going in the right way so I can continue working on this patch, and if that half of the feature is also needed.
Any feedback is welcome, thanks!
Best regards,
Crístian.
next reply other threads:[~2012-03-09 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 16:02 Crístian Viana [this message]
2012-03-09 16:02 ` [Qemu-devel] [PATCH 1/2] QEmu: support disk filenames with comma Crístian Viana
2012-03-09 19:28 ` Anthony Liguori
2012-03-09 16:02 ` [Qemu-devel] [PATCH 2/2] Add myself to the AUTHORS file Crístian Viana
2012-03-09 17:27 ` [Qemu-devel] QEmu: support disk filenames with comma Eric Blake
2012-03-09 18:25 ` Crístian Viana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331308936-30042-1-git-send-email-vianac@linux.vnet.ibm.com \
--to=vianac@linux.vnet.ibm.com \
--cc=agl@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).