From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S74WZ-0006WH-FO for qemu-devel@nongnu.org; Mon, 12 Mar 2012 08:39:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S74W1-00049k-T0 for qemu-devel@nongnu.org; Mon, 12 Mar 2012 08:38:48 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:57323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S74W1-00049D-Ka for qemu-devel@nongnu.org; Mon, 12 Mar 2012 08:38:17 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Mar 2012 12:38:13 -0000 Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2CCcANV2682914 for ; Mon, 12 Mar 2012 12:38:11 GMT Received: from d06av12.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2CCcAKi030485 for ; Mon, 12 Mar 2012 06:38:10 -0600 From: Stefan Hajnoczi Date: Mon, 12 Mar 2012 12:37:57 +0000 Message-Id: <1331555882-31828-3-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1331555882-31828-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1331555882-31828-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 2/7] tracetool: Omit useless QEMU_*_ENABLED() check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Anthony Liguori , Stefan Hajnoczi SystemTap provides a "semaphore" that can optionally be tested before executing a trace event. The purpose of this mechanism is to skip expensive tracing code when the trace event is disabled. For example, some applications may have trace events that format or convert strings for trace events. This expensive processing should only be done in the case where the trace event is enabled. Since QEMU's generated trace events never have such special-purpose code, there is no reason to add the semaphore check. Reviewed-by: Masami Hiramatsu Signed-off-by: Stefan Hajnoczi --- scripts/tracetool | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 701b517..65bd0a1 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -415,9 +415,7 @@ linetoh_dtrace() # Define an empty function for the trace event cat <