* [Qemu-devel] [PATCH] ide: IDENTIFY word 86 bit 14 is reserved
@ 2012-03-13 13:49 Kevin Wolf
2012-03-14 9:35 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2012-03-13 13:49 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, pbonzini
Reserved bits should be cleared to zero.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/ide/core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 6f06d28..771811c 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -150,7 +150,7 @@ static void ide_identify(IDEState *s)
else
put_le16(p + 85, (1 << 14) | 1);
/* 13=flush_cache_ext,12=flush_cache,10=lba48 */
- put_le16(p + 86, (1 << 14) | (1 << 13) | (1 <<12) | (1 << 10));
+ put_le16(p + 86, (1 << 13) | (1 <<12) | (1 << 10));
/* 14=set to 1, 1=smart self test, 0=smart error logging */
put_le16(p + 87, (1 << 14) | 0);
put_le16(p + 88, 0x3f | (1 << 13)); /* udma5 set and supported */
--
1.7.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] ide: IDENTIFY word 86 bit 14 is reserved
2012-03-13 13:49 [Qemu-devel] [PATCH] ide: IDENTIFY word 86 bit 14 is reserved Kevin Wolf
@ 2012-03-14 9:35 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2012-03-14 9:35 UTC (permalink / raw)
To: Kevin Wolf; +Cc: pbonzini, qemu-devel
On Tue, Mar 13, 2012 at 1:49 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Reserved bits should be cleared to zero.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> hw/ide/core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ide/core.c b/hw/ide/core.c
> index 6f06d28..771811c 100644
> --- a/hw/ide/core.c
> +++ b/hw/ide/core.c
> @@ -150,7 +150,7 @@ static void ide_identify(IDEState *s)
> else
> put_le16(p + 85, (1 << 14) | 1);
> /* 13=flush_cache_ext,12=flush_cache,10=lba48 */
> - put_le16(p + 86, (1 << 14) | (1 << 13) | (1 <<12) | (1 << 10));
> + put_le16(p + 86, (1 << 13) | (1 <<12) | (1 << 10));
Looks good. This seems like a copy-paste bug in "LBA48 support (Jens
Axboe)" (c2ff060fd4c7389de2016442e3327538a66696bd) where words 83 and
86 were modified in the same way.
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-14 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-13 13:49 [Qemu-devel] [PATCH] ide: IDENTIFY word 86 bit 14 is reserved Kevin Wolf
2012-03-14 9:35 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).