From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7qZk-0002cC-Gz for qemu-devel@nongnu.org; Wed, 14 Mar 2012 11:57:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7qZi-0000yG-RI for qemu-devel@nongnu.org; Wed, 14 Mar 2012 11:57:20 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:33592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7qZi-0000y2-HB for qemu-devel@nongnu.org; Wed, 14 Mar 2012 11:57:18 -0400 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 14 Mar 2012 15:57:14 -0000 Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2EFvCHM2207962 for ; Wed, 14 Mar 2012 15:57:12 GMT Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2EFvBVf019845 for ; Wed, 14 Mar 2012 09:57:11 -0600 From: Stefan Hajnoczi Date: Wed, 14 Mar 2012 15:57:03 +0000 Message-Id: <1331740626-5053-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v2 0/3] block: enforce constraints on block size properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Stefan Hajnoczi This series ensures we only accept valid block sizes. Although in theory block sizes can vary a lot, the storage protocols (ATA, SCSI) as well as the QEMU block layer implementation impose constraints. Valid QEMU block sizes today must meet: * Power of 2 * Multiple of 512 bytes * Fits into uint16_t Nicolae Mogoreanu found that QEMU allows invalid block sizes to be specified and this can cause it to crash when I/O is performed. Stefan Hajnoczi (3): qerror: fix QERR_PROPERTY_VALUE_OUT_OF_RANGE description qdev: add blocksize property type block: enforce constraints on block size properties block.h | 8 ++++---- hw/qdev-properties.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ hw/qdev.h | 3 +++ qerror.c | 7 ++++++- qerror.h | 4 ++++ 5 files changed, 63 insertions(+), 5 deletions(-) -- 1.7.9.1