From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S86QC-0002OW-HO for qemu-devel@nongnu.org; Thu, 15 Mar 2012 04:52:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S86Q5-0003AA-Ul for qemu-devel@nongnu.org; Thu, 15 Mar 2012 04:52:32 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:34947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S86Q5-00039d-KJ for qemu-devel@nongnu.org; Thu, 15 Mar 2012 04:52:25 -0400 Received: by werp12 with SMTP id p12so2964116wer.4 for ; Thu, 15 Mar 2012 01:52:20 -0700 (PDT) Sender: Alex Barcelo From: Alex Barcelo Date: Thu, 15 Mar 2012 09:52:06 +0100 Message-Id: <1331801528-4646-1-git-send-email-abarcelo@ac.upc.edu> Subject: [Qemu-devel] [PATCH 0/2] Style and bug on linux-user/signal.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Riku Voipio , Alex Barcelo I tried to send a trivial patch and a v2, but I did it horribly wrong and seems that have not yet been updated. I thought that maybe it was a good moment to do things "betterly". The bug is really a typo, because everywhere there is the same 0 comparison. But each comparison is different one from another, so the style is quite messed up and the typo becomes non-trivial to understand. The first patch is a style patch which makes everything check the conditions the same way. The second patch corrects a "== 0" that was missing on an if condition, to be like every other condition. I sent two "[TRIVIAL]" to the lists that are irrelevant with this patch. They are: "sas_ss_flags bug for powerpc" (v2) "Bad zero comparison for sas_ss_flags on powerpc" Alex Barcelo (2): linux-user: Homogeneity on sas_ss_flags checks (signal) linux-user: Bug on a zero comparation with sas_ss_flags linux-user/signal.c | 46 ++++++++++++++++++++++++++-------------------- 1 files changed, 26 insertions(+), 20 deletions(-) -- 1.7.5.4