From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S86QT-0002qU-GK for qemu-devel@nongnu.org; Thu, 15 Mar 2012 04:52:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S86Q6-0003AN-2Q for qemu-devel@nongnu.org; Thu, 15 Mar 2012 04:52:49 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:44013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S86Q5-00039x-Kf for qemu-devel@nongnu.org; Thu, 15 Mar 2012 04:52:25 -0400 Received: by wibhr17 with SMTP id hr17so3484632wib.10 for ; Thu, 15 Mar 2012 01:52:22 -0700 (PDT) Sender: Alex Barcelo From: Alex Barcelo Date: Thu, 15 Mar 2012 09:52:08 +0100 Message-Id: <1331801528-4646-3-git-send-email-abarcelo@ac.upc.edu> In-Reply-To: <1331801528-4646-1-git-send-email-abarcelo@ac.upc.edu> References: <1331801528-4646-1-git-send-email-abarcelo@ac.upc.edu> Subject: [Qemu-devel] [PATCH 2/2] linux-user: Bug on a zero comparation with sas_ss_flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Riku Voipio , Alex Barcelo All sas_ss_flags' 0 check is the same across every architecture. But in PPC there was a bug and it was checked the other way round. It seems a typo and is not architecture dependant, is a POSIX standard and the QEMU way of checking it. Now the signal.c and its sas_ss_flags check should be coherent and correct across archs. Signed-off-by: Alex Barcelo --- linux-user/signal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index d1a2671..d159ada 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -4122,7 +4122,7 @@ static target_ulong get_sigframe(struct target_sigaction *ka, oldsp = env->gpr[1]; if ((ka->sa_flags & TARGET_SA_ONSTACK) && - (sas_ss_flags(oldsp))) { + (sas_ss_flags(oldsp) == 0)) { oldsp = (target_sigaltstack_used.ss_sp + target_sigaltstack_used.ss_size); } -- 1.7.5.4