From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9AkF-00032q-35 for qemu-devel@nongnu.org; Sun, 18 Mar 2012 03:41:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9AkD-0001jF-EV for qemu-devel@nongnu.org; Sun, 18 Mar 2012 03:41:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9AkD-0001j0-6w for qemu-devel@nongnu.org; Sun, 18 Mar 2012 03:41:37 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2I7fY17002273 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 18 Mar 2012 03:41:35 -0400 From: Yonit Halperin Date: Sun, 18 Mar 2012 09:42:39 +0200 Message-Id: <1332056559-8585-1-git-send-email-yhalperi@redhat.com> Subject: [Qemu-devel] [PATCH] monitor: fix client_migrate_info error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Yonit Halperin , kraxel@redhat.com Report QERR_INVALID_PARAMETER when port is missing. Otherwise QERR_UNDEFINED_ERROR will occur. rhbz #795652 Signed-off-by: Yonit Halperin --- monitor.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index d57e7bf..8f46031 100644 --- a/monitor.c +++ b/monitor.c @@ -880,6 +880,11 @@ static int client_migrate_info(Monitor *mon, const QDict *qdict, return -1; } + if (port == -1 && tls_port == -1) { + qerror_report(QERR_MISSING_PARAMETER, "port/tls-port"); + return -1; + } + ret = qemu_spice_migrate_info(hostname, port, tls_port, subject, cb, opaque); if (ret != 0) { -- 1.7.7.6