From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 4/5] virtio-scsi: call unregister_savevm properly
Date: Mon, 19 Mar 2012 17:19:34 +0100 [thread overview]
Message-ID: <1332173975-29099-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1332173975-29099-1-git-send-email-pbonzini@redhat.com>
This fixes a use-after-free when migrating after hot-unplug.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/virtio-scsi.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c
index e607edc..45d54fa 100644
--- a/hw/virtio-scsi.c
+++ b/hw/virtio-scsi.c
@@ -613,5 +613,7 @@ VirtIODevice *virtio_scsi_init(DeviceState *dev, VirtIOSCSIConf *proxyconf)
void virtio_scsi_exit(VirtIODevice *vdev)
{
+ VirtIOSCSI *s = (VirtIOSCSI *)vdev;
+ unregister_savevm(s->qdev, "virtio-scsi", s);
virtio_cleanup(vdev);
}
--
1.7.7.6
next prev parent reply other threads:[~2012-03-19 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 16:19 [Qemu-devel] [PULL 0/5] SCSI patches 2012-03-19 Paolo Bonzini
2012-03-19 16:19 ` [Qemu-devel] [PATCH 1/5] get rid of CONFIG_VIRTIO_SCSI Paolo Bonzini
2012-03-19 16:19 ` [Qemu-devel] [PATCH 2/5] scsi-cd: check ready condition before processing several commands Paolo Bonzini
2012-03-19 16:19 ` [Qemu-devel] [PATCH 3/5] scsi: copy serial number into VPD page 0x83 Paolo Bonzini
2012-03-19 16:19 ` Paolo Bonzini [this message]
2012-03-19 16:19 ` [Qemu-devel] [PATCH 5/5] scsi: add get_dev_path Paolo Bonzini
2012-03-19 21:16 ` [Qemu-devel] [PULL 0/5] SCSI patches 2012-03-19 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332173975-29099-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).