From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9fKO-0000Zl-4U for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:21:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9fK7-0008Qi-Ft for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:20:59 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:53971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9fK7-0008N7-76 for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:20:43 -0400 Received: by mail-pb0-f45.google.com with SMTP id uo5so1463238pbc.4 for ; Mon, 19 Mar 2012 09:20:42 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 19 Mar 2012 17:19:34 +0100 Message-Id: <1332173975-29099-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1332173975-29099-1-git-send-email-pbonzini@redhat.com> References: <1332173975-29099-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 4/5] virtio-scsi: call unregister_savevm properly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This fixes a use-after-free when migrating after hot-unplug. Signed-off-by: Paolo Bonzini --- hw/virtio-scsi.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c index e607edc..45d54fa 100644 --- a/hw/virtio-scsi.c +++ b/hw/virtio-scsi.c @@ -613,5 +613,7 @@ VirtIODevice *virtio_scsi_init(DeviceState *dev, VirtIOSCSIConf *proxyconf) void virtio_scsi_exit(VirtIODevice *vdev) { + VirtIOSCSI *s = (VirtIOSCSI *)vdev; + unregister_savevm(s->qdev, "virtio-scsi", s); virtio_cleanup(vdev); } -- 1.7.7.6