qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: sw@weilnetz.de
Subject: [Qemu-devel] [PATCH 0/6] fix w32 sockets
Date: Tue, 20 Mar 2012 10:49:15 +0100	[thread overview]
Message-ID: <1332236961-22743-1-git-send-email-pbonzini@redhat.com> (raw)

The w32 main loop has been mostly broken by the introduction of the
glib main loop.  glib's g_poll does not use sockets on w32, so we
need a separate approach.

Patch 1 is a simple cleanup that is needed later in the series.

Patch 2 and patch 3 completely separate the way the main loop waits
on POSIX and w32 systems, and drop glib source handling from the w32
main loop.

Patch 4 fixes a longstanding bug in how sockets are handled, also
simplifying the code in the process.  On top of this simplification,
patch 5 starts using g_poll in the w32 main loop and patch 6 adds
back glib source handling.

I didn't test this in the conditions explained in bug 916720, but I
tested both a TCP monitor and an stdio monitor and both work (under
Wine that is).

Stefan, can you please take care of shepherding the patches in
(pinging etc.)?

Paolo Bonzini (6):
  slirp: use socket_set_nonblock
  main loop: use msec-based timeout in glib_select_fill
  main-loop: disable fd_set-based glib integration under w32
  main-loop: interrupt wait when data arrives on a socket
  main-loop: replace WaitForMultipleObjects with g_poll
  main-loop: integrate glib sources for w32

 main-loop.c      |  147 +++++++++++++++++++++++++++++++-----------------------
 main-loop.h      |    1 +
 oslib-win32.c    |    3 +
 slirp/misc.c     |   46 +----------------
 slirp/tcp_subr.c |    4 +-
 5 files changed, 92 insertions(+), 109 deletions(-)

-- 
1.7.7.6

             reply	other threads:[~2012-03-20  9:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20  9:49 Paolo Bonzini [this message]
2012-03-20  9:49 ` [Qemu-devel] [PATCH 1/6] slirp: use socket_set_nonblock Paolo Bonzini
2012-03-20 23:14   ` Stefan Weil
2012-03-21  6:04     ` Paolo Bonzini
2012-03-20  9:49 ` [Qemu-devel] [PATCH 2/6] main loop: use msec-based timeout in glib_select_fill Paolo Bonzini
2012-03-20  9:49 ` [Qemu-devel] [PATCH 3/6] main-loop: disable fd_set-based glib integration under w32 Paolo Bonzini
2012-03-20  9:49 ` [Qemu-devel] [PATCH 4/6] main-loop: interrupt wait when data arrives on a socket Paolo Bonzini
2012-03-20  9:49 ` [Qemu-devel] [PATCH 5/6] main-loop: replace WaitForMultipleObjects with g_poll Paolo Bonzini
2012-04-04 20:44   ` Blue Swirl
2012-04-04 21:07     ` Peter Maydell
2012-04-05  8:12     ` Paolo Bonzini
2012-04-05  8:48       ` Peter Maydell
2012-04-05  8:56         ` Paolo Bonzini
2012-03-20  9:49 ` [Qemu-devel] [PATCH 6/6] main-loop: integrate glib sources for w32 Paolo Bonzini
2012-03-20 23:32 ` [Qemu-devel] [PATCH 0/6] fix w32 sockets Stefan Weil
2012-04-03 11:06 ` Paolo Bonzini
2012-04-03 20:24   ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332236961-22743-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).