From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAgYF-0002ks-Jf for qemu-devel@nongnu.org; Thu, 22 Mar 2012 07:51:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAgY7-0004ip-Dv for qemu-devel@nongnu.org; Thu, 22 Mar 2012 07:51:31 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:55089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAgY7-0004iC-53 for qemu-devel@nongnu.org; Thu, 22 Mar 2012 07:51:23 -0400 Received: by wgbfm10 with SMTP id fm10so1298262wgb.10 for ; Thu, 22 Mar 2012 04:51:20 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 22 Mar 2012 12:51:04 +0100 Message-Id: <1332417072-20329-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1332417072-20329-1-git-send-email-pbonzini@redhat.com> References: <1332417072-20329-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 02/10] qapi: fail hard on stack imbalance List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, eblake@redhat.com, anthony@codemonkey.vs, lcapitulino@redhat.com QmpOutputVisitor will segfault if an imbalanced end function is called. So we can abort in QmpInputVisitor too. Signed-off-by: Paolo Bonzini --- qapi/qmp-input-visitor.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c index e6b6152..b4013cc 100644 --- a/qapi/qmp-input-visitor.c +++ b/qapi/qmp-input-visitor.c @@ -77,11 +77,8 @@ static void qmp_input_push(QmpInputVisitor *qiv, const QObject *obj, Error **err static void qmp_input_pop(QmpInputVisitor *qiv, Error **errp) { + assert(qiv->nb_stack > 0); qiv->nb_stack--; - if (qiv->nb_stack < 0) { - error_set(errp, QERR_BUFFER_OVERRUN); - return; - } } static void qmp_input_start_struct(Visitor *v, void **obj, const char *kind, -- 1.7.9.1