qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Emre Ersin <emre.ersin@gmail.com>, Stefan Weil <sw@weilnetz.de>
Subject: [Qemu-devel] [PATCH v2 1/2] Makefile: Set default locale C
Date: Sun, 25 Mar 2012 21:11:10 +0200	[thread overview]
Message-ID: <1332702671-32076-2-git-send-email-sw@weilnetz.de> (raw)
In-Reply-To: <1332702671-32076-1-git-send-email-sw@weilnetz.de>

Some locale settings let make fail or create wrong results,
so set always the C locale.

* Conversion from lower to upper case with tr does not convert
  lower case 'i' to 'I' with locale tr_TR.UTF-8. This results in
  wrong entries in config-host.h like these ones:

  #define CONFIG_QEMU_PREFiX "/usr/local"
  #define CONFIG_QEMU_BiNDiR "/usr/local/bin"

  This problem was reported by Emre Ersin.

* The html files created from texi input contain non english
  titles like "Anhang" with locale de_DE.UTF-8.

The locale variables are not explicitly exported here to avoid
possible problems with the 'export' keyword. Either they are
already environment variables when make is called - then the
new values are passed to child processes, or there are no such
environment variables - then the default value C is used.

v2:
Enhanced commit message.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 Makefile |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index 8d6b558..3f899e2 100644
--- a/Makefile
+++ b/Makefile
@@ -37,6 +37,11 @@ $(call set-vpath, $(SRC_PATH):$(SRC_PATH)/hw)
 
 LIBS+=-lz $(LIBS_TOOLS)
 
+# Set default locale for commands like tr and others.
+LANG=C
+LC_ALL=C
+LC_CTYPE=C
+
 HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF)
 
 ifdef BUILD_DOCS
-- 
1.7.9

  reply	other threads:[~2012-03-25 19:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-25 19:11 [Qemu-devel] [Patch 0/2] Fix QEMU configure / make with Turkish (and maybe other) locale Stefan Weil
2012-03-25 19:11 ` Stefan Weil [this message]
2012-03-25 19:11 ` [Qemu-devel] [PATCH 2/2] configure: Set default locale C (fix build for Turkish locale) Stefan Weil
2012-03-25 19:27 ` [Qemu-devel] [Patch 0/2] Fix QEMU configure / make with Turkish (and maybe other) locale Andreas Färber
2012-03-25 19:48   ` Stefan Weil
2012-03-26 19:25     ` Eric Blake
2012-03-25 19:52   ` Peter Maydell
2012-03-25 20:16     ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332702671-32076-2-git-send-email-sw@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=emre.ersin@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).