From: Alon Levy <alevy@redhat.com>
To: spice-devel@freedesktop.org, qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: [Qemu-devel] [PATCH] spice_info: add mouse_mode
Date: Mon, 26 Mar 2012 14:47:33 +0200 [thread overview]
Message-ID: <1332766053-9063-3-git-send-email-alevy@redhat.com> (raw)
In-Reply-To: <1332766053-9063-1-git-send-email-alevy@redhat.com>
Add mouse_mode, either server or mouse, to qmp and hmp commands, based
on spice_server_is_server_mouse added in spice-server 0.10.3.
Signed-off-by: Alon Levy <alevy@redhat.com>
---
hmp.c | 2 ++
qapi-schema.json | 7 ++++++-
ui/spice-core.c | 5 +++++
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/hmp.c b/hmp.c
index 9cf2d13..c1224fb 100644
--- a/hmp.c
+++ b/hmp.c
@@ -350,6 +350,8 @@ void hmp_info_spice(Monitor *mon)
}
monitor_printf(mon, " auth: %s\n", info->auth);
monitor_printf(mon, " compiled: %s\n", info->compiled_version);
+ monitor_printf(mon, " mouse-mode: %s\n",
+ info->has_mouse_mode ? info->mouse_mode : "unknown");
if (!info->has_channels || info->channels == NULL) {
monitor_printf(mon, "Channels: none\n");
diff --git a/qapi-schema.json b/qapi-schema.json
index 0d11d6e..72c0080 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -654,6 +654,11 @@
# 'spice' uses SASL or direct TLS authentication, depending on command
# line options
#
+# @mouse-mode: #optional current server mouse mode if spice server is new
+# enough and exposes this information.
+# 'client' if client side
+# 'server' if server side
+#
# @channels: a list of @SpiceChannel for each active spice channel
#
# Since: 0.14.0
@@ -661,7 +666,7 @@
{ 'type': 'SpiceInfo',
'data': {'enabled': 'bool', '*host': 'str', '*port': 'int',
'*tls-port': 'int', '*auth': 'str', '*compiled-version': 'str',
- '*channels': ['SpiceChannel']} }
+ '*mouse-mode': 'str', '*channels': ['SpiceChannel']} }
##
# @query-spice
diff --git a/ui/spice-core.c b/ui/spice-core.c
index a468524..0155dba 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -462,6 +462,11 @@ SpiceInfo *qmp_query_spice(Error **errp)
info->tls_port = tls_port;
}
+#if SPICE_SERVER_VERSION >= 0x000a03 /* 0.10.3 */
+ info->has_mouse_mode = true;
+ info->mouse_mode = g_strdup(spice_server_is_server_mouse(spice_server) ?
+ "server" : "client");
+#endif
/* for compatibility with the original command */
info->has_channels = true;
info->channels = qmp_query_spice_channels();
--
1.7.9.3
next prev parent reply other threads:[~2012-03-26 12:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 12:47 [Qemu-devel] [PATCH qemu+spice] expose server mouse status Alon Levy
2012-03-26 12:47 ` [Qemu-devel] [PATCH] server: export spice_server_is_server_mouse predicate Alon Levy
2012-03-26 12:47 ` Alon Levy [this message]
2012-03-26 13:06 ` [Qemu-devel] [PATCH] spice_info: add mouse_mode Gerd Hoffmann
2012-03-26 13:30 ` Alon Levy
2012-03-26 13:46 ` Gerd Hoffmann
2012-03-26 13:36 ` Alon Levy
2012-03-26 14:15 ` [Qemu-devel] [PATCH v2] " Alon Levy
2012-03-29 9:08 ` Gerd Hoffmann
2012-03-29 20:16 ` Alon Levy
2012-03-29 20:19 ` Anthony Liguori
2012-03-29 20:54 ` Alon Levy
2012-03-29 21:23 ` [Qemu-devel] [PATCH v3] " Alon Levy
2012-03-30 8:12 ` Gerd Hoffmann
2012-03-30 19:25 ` Alon Levy
2012-04-01 12:06 ` Alon Levy
2012-03-26 12:58 ` [Qemu-devel] [Spice-devel] [PATCH qemu+spice] expose server mouse status Arnon Gilboa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332766053-9063-3-git-send-email-alevy@redhat.com \
--to=alevy@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).