From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCVOh-0001WQ-BN for qemu-devel@nongnu.org; Tue, 27 Mar 2012 08:21:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCVOa-0000Lx-Um for qemu-devel@nongnu.org; Tue, 27 Mar 2012 08:21:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCVOa-0000Lm-Na for qemu-devel@nongnu.org; Tue, 27 Mar 2012 08:21:04 -0400 From: Luiz Capitulino Date: Tue, 27 Mar 2012 09:20:49 -0300 Message-Id: <1332850851-4059-12-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1332850851-4059-1-git-send-email-lcapitulino@redhat.com> References: <1332850851-4059-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 11/13] qmp: add and use q type specifier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@us.ibm.com Cc: Paolo Bonzini , qemu-devel@nongnu.org From: Paolo Bonzini "O" is being used by the transaction and qom-set commands to mean "any QObject", but it really means "do not validate the argument list". Add a new specifier with the correct meaning. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- monitor.c | 3 +++ qmp-commands.hx | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 2ff1e0b..8946a10 100644 --- a/monitor.c +++ b/monitor.c @@ -4157,6 +4157,9 @@ static int check_client_args_type(const QDict *client_args, case 'O': assert(flags & QMP_ACCEPT_UNKNOWNS); break; + case 'q': + /* Any QObject can be passed. */ + break; case '/': case '.': /* diff --git a/qmp-commands.hx b/qmp-commands.hx index c626ba8..9447871 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -708,7 +708,7 @@ EQMP }, { .name = "transaction", - .args_type = "actions:O", + .args_type = "actions:q", .mhandler.cmd_new = qmp_marshal_input_transaction, }, @@ -2125,7 +2125,7 @@ EQMP { .name = "qom-set", - .args_type = "path:s,property:s,opts:O", + .args_type = "path:s,property:s,value:q", .mhandler.cmd_new = qmp_qom_set, }, -- 1.7.9.2.384.g4a92a