From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCVOW-0000ux-8o for qemu-devel@nongnu.org; Tue, 27 Mar 2012 08:21:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCVOP-0000JC-4y for qemu-devel@nongnu.org; Tue, 27 Mar 2012 08:20:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35167) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCVOO-0000Iv-Tb for qemu-devel@nongnu.org; Tue, 27 Mar 2012 08:20:53 -0400 From: Luiz Capitulino Date: Tue, 27 Mar 2012 09:20:42 -0300 Message-Id: <1332850851-4059-5-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1332850851-4059-1-git-send-email-lcapitulino@redhat.com> References: <1332850851-4059-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 04/13] qapi: fail hard on stack imbalance List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@us.ibm.com Cc: Paolo Bonzini , qemu-devel@nongnu.org From: Paolo Bonzini QmpOutputVisitor will segfault if an imbalanced end function is called. So we can abort in QmpInputVisitor too. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- qapi/qmp-input-visitor.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c index e6b6152..b4013cc 100644 --- a/qapi/qmp-input-visitor.c +++ b/qapi/qmp-input-visitor.c @@ -77,11 +77,8 @@ static void qmp_input_push(QmpInputVisitor *qiv, const QObject *obj, Error **err static void qmp_input_pop(QmpInputVisitor *qiv, Error **errp) { + assert(qiv->nb_stack > 0); qiv->nb_stack--; - if (qiv->nb_stack < 0) { - error_set(errp, QERR_BUFFER_OVERRUN); - return; - } } static void qmp_input_start_struct(Visitor *v, void **obj, const char *kind, -- 1.7.9.2.384.g4a92a